* Warning in block code
@ 2009-06-17 1:39 Benjamin Herrenschmidt
2009-06-17 4:36 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2009-06-17 1:39 UTC (permalink / raw)
To: Jens Axboe; +Cc: linuxppc-dev list
Hoy !
I see that:
block/blk-settings.c: In function ‘blk_set_default_limits’:
block/blk-settings.c:115: warning: large integer implicitly truncated to unsigned type
Comes from
lim->bounce_pfn = BLK_BOUNCE_ANY;
With BLK_BOUNCE_ANY being a
include/linux/blkdev.h:#define BLK_BOUNCE_ANY (-1ULL)
And struct queue_limit.bounce_pfn is:
unsigned long bounce_pfn;
(The warning is fishy as both quantities are unsigned, but there -is- truncation
happening here).
Cheers,
Ben.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Warning in block code
2009-06-17 1:39 Warning in block code Benjamin Herrenschmidt
@ 2009-06-17 4:36 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2009-06-17 4:36 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev list
On Wed, Jun 17 2009, Benjamin Herrenschmidt wrote:
> Hoy !
>
> I see that:
>
> block/blk-settings.c: In function ???blk_set_default_limits???:
> block/blk-settings.c:115: warning: large integer implicitly truncated to unsigned type
>
> Comes from
>
> lim->bounce_pfn = BLK_BOUNCE_ANY;
>
> With BLK_BOUNCE_ANY being a
>
> include/linux/blkdev.h:#define BLK_BOUNCE_ANY (-1ULL)
>
> And struct queue_limit.bounce_pfn is:
>
> unsigned long bounce_pfn;
>
> (The warning is fishy as both quantities are unsigned, but there -is-
> truncation happening here).
Should be safe to just make it -1UL now.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-17 4:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-17 1:39 Warning in block code Benjamin Herrenschmidt
2009-06-17 4:36 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).