From: "M. Mohan Kumar" <mohan@in.ibm.com>
To: Neil Horman <nhorman@redhat.com>
Cc: linuxppc-dev@ozlabs.org, Simon Horman <horms@verge.net.au>,
kexec@lists.infradead.org, miltonm@bga.com
Subject: Re: [PATCH] Do not inline putprops function
Date: Wed, 17 Jun 2009 19:04:35 +0530 [thread overview]
Message-ID: <20090617133435.GB4059@in.ibm.com> (raw)
In-Reply-To: <20090617130413.GB2774@localhost.localdomain>
On Wed, Jun 17, 2009 at 09:04:13AM -0400, Neil Horman wrote:
> On Wed, Jun 17, 2009 at 10:26:35PM +1000, Michael Ellerman wrote:
> >
> > What compiler version are you using? Does the behaviour change if you
> > use a newer/older compiler? It sounds to me like there's some deeper bug
> > and your patch is just papering over it.
> >
I tried with gcc 4.3.2. Let me try with a recent version and update.
> Agreed, this doesn't make any sense. Try changing the compiler version to see if
> the problem goes away or stops. It might also be worthwhile to dump the
> contents of the device tree at the start and end of the kexec process. If the
> changing of how a function is inlined is causing a hang, its likely changing how
> the putprops function is writing information to the device tree. Understanding
> what that change is will likely provide clues to how the code has changed.
Neil, there was no code change in fs2dt.c
Regards,
M. Mohan Kumar
next prev parent reply other threads:[~2009-06-17 13:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 11:34 [PATCH] Do not inline putprops function M. Mohan Kumar
2009-06-17 11:45 ` Simon Horman
2009-06-17 11:59 ` M. Mohan Kumar
2009-06-17 12:26 ` Michael Ellerman
2009-06-17 13:04 ` Neil Horman
2009-06-17 13:34 ` M. Mohan Kumar [this message]
2009-06-17 14:05 ` Neil Horman
2009-06-17 14:26 ` M. Mohan Kumar
2009-06-17 14:40 ` Neil Horman
2009-06-23 12:55 ` M. Mohan Kumar
2009-06-23 13:56 ` Neil Horman
2009-06-24 0:27 ` Michael Ellerman
2009-08-03 5:49 ` M. Mohan Kumar
2009-08-05 16:49 ` M. Mohan Kumar
2009-08-06 14:24 ` Michael Ellerman
2009-08-07 14:35 ` M. Mohan Kumar
2009-08-07 14:54 ` M. Mohan Kumar
2009-08-10 1:51 ` Michael Ellerman
2009-08-10 7:37 ` Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090617133435.GB4059@in.ibm.com \
--to=mohan@in.ibm.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=nhorman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).