linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: "Steven A. Falco" <sfalco@harris.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
	Stefan Roese <sr@denx.de>,
	linux-mtd@lists.infradead.org,
	Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [Question] m25p80 driver versus spi clock rate
Date: Wed, 24 Jun 2009 08:13:00 -0700	[thread overview]
Message-ID: <200906240813.01220.david-b@pacbell.net> (raw)
In-Reply-To: <4A423750.8080605@harris.com>

On Wednesday 24 June 2009, Steven A. Falco wrote:
> Your changes to bitbang_work look good.

You tested?


> I'm not clear on why you first set do_setup = -1 but later 
> use do_setup = 1.  Perhaps they should both be "1".  Other than that,
> 
> Acked-by: Steven A. Falco <sfalco@harris.com>

The "-1" is for the init path, "1" for per-transfer overrides;
this way it avoids some extra calls to set up the bits/speed.

  parent reply	other threads:[~2009-06-24 15:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4A3FEE98.60700@harris.com>
     [not found] ` <200906231256.19736.david-b@pacbell.net>
     [not found]   ` <4A413BB2.8060704@harris.com>
     [not found]     ` <200906231408.26912.david-b@pacbell.net>
2009-06-23 21:49       ` [Question] m25p80 driver versus spi clock rate Steven A. Falco
2009-06-23 22:38         ` David Brownell
2009-06-24 14:25           ` Steven A. Falco
2009-06-24 14:33             ` Stefan Roese
2009-06-24 14:36               ` Steven A. Falco
2009-06-24 14:50                 ` Stefan Roese
2009-06-24 15:13             ` David Brownell [this message]
2009-06-24 16:14               ` Steven A. Falco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906240813.01220.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sfalco@harris.com \
    --cc=sr@denx.de \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).