From: David Brownell <david-b@pacbell.net>
To: "Steven A. Falco" <sfalco@harris.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
Stefan Roese <sr@denx.de>
Subject: Re: Subject: [PATCH v7] spi: Add PPC4xx SPI driver
Date: Thu, 25 Jun 2009 21:04:46 -0700 [thread overview]
Message-ID: <200906252104.46189.david-b@pacbell.net> (raw)
In-Reply-To: <4A43CC2C.1030409@harris.com>
On Thursday 25 June 2009, Steven A. Falco wrote:
> + if (spi->mode & ~MODEBITS) {
> + dev_dbg(&spi->dev, "setup: unsupported mode bits %x\n",
> + spi->mode & ~MODEBITS);
> + return -EINVAL;
> + }
This wasn't tested against 2.6.30-rc1 was it?
See the recent fixup patch I sent. There's a spi_master->modebits
mask that should have been initialized, and which eliminates the
need for tests like that ...
> + dev_dbg(&spi->dev, "%s: mode %d, %u bpw, %d hz\n",
> + __func__, spi->mode, spi->bits_per_word,
> + spi->max_speed_hz);
> +
... also the SPI core now provides a *standard* format debug
message for that stuff. It also handles one more thing, which
I expect to see fixed in a v8 of this patch ... :)
- Dave
next prev parent reply other threads:[~2009-06-26 4:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 19:12 Subject: [PATCH v7] spi: Add PPC4xx SPI driver Steven A. Falco
2009-06-26 4:04 ` David Brownell [this message]
2009-06-26 16:17 ` Steven A. Falco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906252104.46189.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfalco@harris.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).