From: David Miller <davem@davemloft.net>
To: avorontsov@ru.mvista.com
Cc: netdev@vger.kernel.org, shemminger@vyatta.com,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] sky2: Fix checksum endianness
Date: Fri, 26 Jun 2009 09:28:58 -0700 (PDT) [thread overview]
Message-ID: <20090626.092858.64239359.davem@davemloft.net> (raw)
In-Reply-To: <20090626145159.GA2242@oksana.dev.rtsoft.ru>
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Date: Fri, 26 Jun 2009 18:51:59 +0400
> sky2 driver on PowerPC targets floods kernel log with following errors:
>
> eth1: hw csum failure.
> Call Trace:
> [ef84b8a0] [c00075e4] show_stack+0x50/0x160 (unreliable)
> [ef84b8d0] [c02fa178] netdev_rx_csum_fault+0x3c/0x5c
> [ef84b8f0] [c02f6920] __skb_checksum_complete_head+0x7c/0x84
> [ef84b900] [c02f693c] __skb_checksum_complete+0x14/0x24
> [ef84b910] [c0337e08] tcp_v4_rcv+0x4c8/0x6f8
> [ef84b940] [c031a9c8] ip_local_deliver+0x98/0x210
> [ef84b960] [c031a788] ip_rcv+0x38c/0x534
> [ef84b990] [c0300338] netif_receive_skb+0x260/0x36c
> [ef84b9c0] [c025de00] sky2_poll+0x5dc/0xcf8
> [ef84ba20] [c02fb7fc] net_rx_action+0xc0/0x144
>
> The NIC is Yukon-2 EC chip revision 1.
>
> Converting checksum field from le16 to CPU byte order fixes the issue.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Applied, thank you!
prev parent reply other threads:[~2009-06-26 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 14:51 [PATCH] sky2: Fix checksum endianness Anton Vorontsov
2009-06-26 16:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090626.092858.64239359.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).