linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/85xx: Don't scan for TBI PHY addresses on MPC8569E-MDS boards
Date: Tue, 14 Jul 2009 17:33:04 +0400	[thread overview]
Message-ID: <20090714133304.GA28970@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090701173925.GA22134@oksana.dev.rtsoft.ru>

On Wed, Jul 01, 2009 at 09:39:25PM +0400, Anton Vorontsov wrote:
> Sometimes (e.g. when there are no UEMs attached to a board)
> fsl_pq_mdio_find_free() fails to find a spare address for a TBI PHY,
> this is because get_phy_id() returns bogus 0x0000ffff values
> (0xffffffff is expected), and therefore mdio bus probing fails with
> the following message:
> 
>   fsl-pq_mdio: probe of e0082120.mdio failed with error -16
> 
> And obviously ethernet doesn't work after this.
> 
> This patch solves the problem by adding tbi-phy node into mdio node,
> so that we won't scan for spare addresses, we'll just use a fixed one.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>

Kumar,

I believe this patch is suitable for 2.6.31, no?

Thanks,

> ---
>  arch/powerpc/boot/dts/mpc8569mds.dts |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boot/dts/mpc8569mds.dts
> index 2577f37..baa4ac7 100644
> --- a/arch/powerpc/boot/dts/mpc8569mds.dts
> +++ b/arch/powerpc/boot/dts/mpc8569mds.dts
> @@ -502,6 +502,10 @@
>  				reg = <0x6>;
>  				device_type = "ethernet-phy";
>  			};
> +			tbi-phy@11 {
> +				reg = <0x11>;
> +				device_type = "tbi-phy";
> +			};
>  		};
>  		mdio@3520 {
>  			#address-cells = <1>;
> -- 
> 1.6.3.3
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

  reply	other threads:[~2009-07-14 13:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01 17:39 [PATCH] powerpc/85xx: Don't scan for TBI PHY addresses on MPC8569E-MDS boards Anton Vorontsov
2009-07-14 13:33 ` Anton Vorontsov [this message]
2009-07-30  4:16 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090714133304.GA28970@oksana.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=cbouatmailru@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).