From: Wolfgang Denk <wd@denx.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] MPC52xx FEC: be more conservative when setting MII_SPEED register
Date: Fri, 17 Jul 2009 14:25:33 +0200 [thread overview]
Message-ID: <20090717122533.09431832E416@gemini.denx.de> (raw)
In-Reply-To: <fa686aa40907161548n1658afaei8dce2d893222019c@mail.gmail.com>
Dear Grant Likely,
In message <fa686aa40907161548n1658afaei8dce2d893222019c@mail.gmail.com> you wrote:
>
> Mostly good. One comment below. When it's resolved, feel free to add
> my acked-by line. Thanks for getting this done.
...
> Just thought of something. If it cannot find the clock, then wouldn't
> it be better to just use the maximum divider and print a warning
> instead of bailing completely? This goes for the other patch as well.
Will change this for both patches. Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Program maintenance is an entropy-increasing process, and even its
most skilfull execution only delays the subsidence of the system into
unfixable obsolescence. - Fred Brooks, "The Mythical Man Month"
next prev parent reply other threads:[~2009-07-17 12:25 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 20:20 [PATCH 00/04] Add support for ARIA board Wolfgang Denk
2009-05-06 20:20 ` [PATCH 01/04] mpc5121: prepare support for additional boards Wolfgang Denk
2009-05-06 20:29 ` Grant Likely
2009-05-06 20:40 ` Wolfgang Denk
2009-05-06 21:11 ` Grant Likely
2009-05-06 20:20 ` [PATCH 02/04] ARIA: add device tree source file Wolfgang Denk
2009-05-06 20:21 ` [PATCH 03/04] mpc5121: add support for ARIA board Wolfgang Denk
2009-05-06 20:21 ` [PATCH 04/04] ARIA: add default config file Wolfgang Denk
2009-05-06 20:21 ` [PATCH 05/04] *** NOT FOR RELEASE *** HACK *** Work around MII clock issue *** Wolfgang Denk
2009-05-07 8:26 ` Joakim Tjernlund
2009-05-07 9:19 ` Wolfgang Denk
2009-05-07 9:30 ` Joakim Tjernlund
2009-05-08 2:09 ` John Rigby
2009-06-06 22:16 ` Wolfgang Denk
2009-06-06 22:27 ` John Rigby
2009-06-06 23:21 ` Wolfgang Denk
2009-06-07 0:08 ` John Rigby
2009-06-07 8:20 ` Wolfram Sang
2009-06-07 20:34 ` Wolfgang Denk
2009-06-08 7:46 ` Wolfgang Grandegger
2009-06-08 8:19 ` Wolfgang Denk
2009-06-08 14:39 ` Grant Likely
2009-06-08 14:37 ` Grant Likely
2009-06-11 20:19 ` [PATCH] mpc5xxx_get_bus_frequency(): use common code on MPC512x and MPC52xx Wolfgang Denk
2009-06-17 6:14 ` Grant Likely
2009-06-17 6:21 ` Grant Likely
2009-06-11 20:19 ` [PATCH RFC] fs_enet/mii-fec.c: fix MII speed calculation Wolfgang Denk
2009-07-14 13:42 ` [PATCH v2] " Wolfgang Denk
2009-07-15 15:18 ` [PATCH 1/2 v3] " Wolfgang Denk
2009-07-15 17:17 ` Grant Likely
2009-07-16 21:21 ` Wolfgang Denk
2009-07-16 22:37 ` Grant Likely
2009-07-16 21:42 ` [PATCH 1/2 v4] " Wolfgang Denk
2009-07-16 22:44 ` Grant Likely
2009-07-17 12:24 ` Wolfgang Denk
2009-07-17 9:33 ` Wolfram Sang
2009-07-17 12:32 ` Wolfgang Denk
2009-07-17 12:27 ` [PATCH 1/2 v5] " Wolfgang Denk
2009-07-17 14:41 ` Grant Likely
2009-07-17 16:21 ` David Miller
2009-07-17 16:48 ` David Miller
2009-07-17 12:27 ` [PATCH 2/2 v3] MPC52xx FEC: be more conservative when setting MII_SPEED register Wolfgang Denk
2009-07-17 12:59 ` [PATCH 2/2 v4] " Wolfgang Denk
2009-07-17 14:45 ` Grant Likely
2009-07-17 17:51 ` Wolfgang Denk
2009-07-17 18:31 ` Grant Likely
2009-07-16 21:42 ` [PATCH 2/2 v2] " Wolfgang Denk
2009-07-16 22:48 ` Grant Likely
2009-07-17 12:25 ` Wolfgang Denk [this message]
2009-07-17 9:47 ` Wolfram Sang
2009-07-17 12:35 ` Wolfgang Denk
2009-07-15 15:18 ` [PATCH 2/2] " Wolfgang Denk
2009-07-15 17:18 ` Grant Likely
2009-07-16 21:21 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090717122533.09431832E416@gemini.denx.de \
--to=wd@denx.de \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).