From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 7D4A9B7088 for ; Sat, 18 Jul 2009 03:51:47 +1000 (EST) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by ozlabs.org (Postfix) with ESMTP id C0A4FDDD1C for ; Sat, 18 Jul 2009 03:51:44 +1000 (EST) To: Grant Likely From: Wolfgang Denk Subject: Re: [PATCH 2/2 v4] MPC52xx FEC: be more conservative when setting MII_SPEED register Mime-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 In-reply-to: References: <1247833628-15952-2-git-send-email-wd@denx.de> <1247835545-18650-1-git-send-email-wd@denx.de> Date: Fri, 17 Jul 2009 19:51:38 +0200 Message-Id: <20090717175138.97CB2832E416@gemini.denx.de> Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Dear Grant Likely, In message you wrote: > > > drivers/net/fec_mpc52xx.c | 25 ++++++++++++++++++++++--- > > drivers/net/fec_mpc52xx_phy.c | 23 ++++++++++++++++++++--- > > Blech. now this block of duplicated code I don't like. This is all > one device, so surely the mdio speed can be calculated once and used > for both drivers.... let me think about this for a bit. 'course this > problem is all rolled up in the nastiness of having two drivers > working on the same device. I suspect is was a mistake to split up > all the powerpc ethernet drivers into separate of_platform drivers. If you like, I can re-introduce the mpc5xxx_get_mii_speed() I unrolled upon your request (with or without re-using it for the MPC512x case). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de What is mind? No matter. What is matter? Never mind. -- Thomas Hewitt Key, 1799-1875