linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Anton Vorontsov <avorontsov@ru.mvista.com>,
	Sam Ravnborg <sam@ravnborg.org>
Cc: linuxppc-dev@ozlabs.org, Steven Rostedt <srostedt@redhat.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/2] Makefile: Never use -fno-omit-frame-pointer
Date: Sat, 18 Jul 2009 14:01:45 +0200	[thread overview]
Message-ID: <20090718120145.GB31007@elte.hu> (raw)
In-Reply-To: <20090714133716.GC28970@oksana.dev.rtsoft.ru>


* Anton Vorontsov <avorontsov@ru.mvista.com> wrote:

> On Wed, Jun 17, 2009 at 12:16:30AM +0400, Anton Vorontsov wrote:
> > According to Segher Boessenkool and GCC manual, -fomit-frame-pointer
> > is only the default when optimising on archs/ABIs where it doesn't
> > hinder debugging and -pg. So, we do not get it by default on x86,
> > not at any optimisation level.
> > 
> > On the other hand, *using* -fno-omit-frame-pointer causes gcc to
> > produce buggy code on PowerPC targets.
> > 
> > If Segher and GCC manual are right, this patch should be a no-op
> > for all arches except PowerPC, where the patch fixes gcc issues.
> > 
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> > ---
> > 
> > See this thread for more discussion:
> > http://osdir.com/ml/linux-kernel/2009-05/msg01754.html
> > 
> > p.s.
> > Obviously, I didn't test this patch on anything else but PPC32. ;-)
> > 
> > Segher, do you know if all GCC versions that we support for
> > building Linux are behaving the way that GCC manual describe?
> 
> No news is good news... Ingo, can we merge this into -tip for 
> testing?

Changes to the top level Makefile should really go via Sam's kbuild 
tree.

	Ingo

  parent reply	other threads:[~2009-07-18 12:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16 20:16 [PATCH RFC 1/2] Makefile: Never use -fno-omit-frame-pointer Anton Vorontsov
2009-07-14 13:37 ` Anton Vorontsov
2009-07-14 13:46   ` Segher Boessenkool
2009-07-18 12:01   ` Ingo Molnar [this message]
2009-09-04 16:53     ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090718120145.GB31007@elte.hu \
    --to=mingo@elte.hu \
    --cc=avorontsov@ru.mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sam@ravnborg.org \
    --cc=srostedt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).