From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org,
Jean Delvare <khali@linux-fr.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/7] spi: Add support for device table matching
Date: Thu, 30 Jul 2009 02:32:23 +0400 [thread overview]
Message-ID: <20090729223223.GA15280@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090729214446.GB1728@fluff.org.uk>
On Wed, Jul 29, 2009 at 10:44:46PM +0100, Ben Dooks wrote:
[...]
> > + const struct spi_device_id *id_table;
> > + int (*probe_id)(struct spi_device *spi,
> > + const struct spi_device_id *id);
>
> how about leaving it at just probe and have either a call or a field
> in the device that you can look at to see if this was a new style of
> call?
There are no technical difficulties with that, but it would be
inconsitent wrt other "device table"-aware buses (i2c, pci, of).
Note that I'm getting rid of probe_id function in patch 5/7, as a
cleanup step. I want to keep "new features" and "api cleanups"
separate. That way it's easier to review the changes.
Thanks!
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-07-29 22:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 17:03 [PATCH 0/7] Device table matching for SPI subsystem Anton Vorontsov
2009-07-29 17:04 ` [PATCH 1/7] spi: Add support for device table matching Anton Vorontsov
2009-07-29 21:44 ` Ben Dooks
2009-07-29 22:32 ` Anton Vorontsov [this message]
2009-07-29 22:40 ` Anton Vorontsov
2009-07-30 2:12 ` Anton Vorontsov
2009-08-04 2:21 ` David Brownell
2009-08-05 1:06 ` Anton Vorontsov
2009-07-29 17:05 ` [PATCH 2/7] mtd: m25p80: Convert to " Anton Vorontsov
2009-07-29 17:05 ` [PATCH 3/7] of: Remove "stm,m25p40" alias Anton Vorontsov
2009-07-29 17:05 ` [PATCH 4/7] spi: Prefix modalias with "spi:" Anton Vorontsov
2009-08-12 4:12 ` Mike Frysinger
2009-07-29 17:05 ` [PATCH 5/7] spi: Merge probe and probe_id callbacks Anton Vorontsov
2009-07-29 17:05 ` [PATCH 6/7] hwmon: adxx: Convert to device table matching Anton Vorontsov
2009-07-29 17:05 ` [PATCH 7/7] hwmon: lm70: " Anton Vorontsov
2009-08-04 2:16 ` [PATCH 0/7] Device table matching for SPI subsystem David Brownell
2009-08-05 0:54 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090729223223.GA15280@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=dbrownell@users.sourceforge.net \
--cc=dwmw2@infradead.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).