From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 8254CB7B64 for ; Thu, 30 Jul 2009 08:32:26 +1000 (EST) Received: from buildserver.ru.mvista.com (unknown [213.79.90.228]) by ozlabs.org (Postfix) with ESMTP id 1D071DDD1B for ; Thu, 30 Jul 2009 08:32:25 +1000 (EST) Date: Thu, 30 Jul 2009 02:32:23 +0400 From: Anton Vorontsov To: Ben Dooks Subject: Re: [PATCH 1/7] spi: Add support for device table matching Message-ID: <20090729223223.GA15280@oksana.dev.rtsoft.ru> References: <20090729170345.GA26787@oksana.dev.rtsoft.ru> <20090729170457.GA4803@oksana.dev.rtsoft.ru> <20090729214446.GB1728@fluff.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20090729214446.GB1728@fluff.org.uk> Cc: David Brownell , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, Jean Delvare , Andrew Morton , David Woodhouse Reply-To: avorontsov@ru.mvista.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jul 29, 2009 at 10:44:46PM +0100, Ben Dooks wrote: [...] > > + const struct spi_device_id *id_table; > > + int (*probe_id)(struct spi_device *spi, > > + const struct spi_device_id *id); > > how about leaving it at just probe and have either a call or a field > in the device that you can look at to see if this was a new style of > call? There are no technical difficulties with that, but it would be inconsitent wrt other "device table"-aware buses (i2c, pci, of). Note that I'm getting rid of probe_id function in patch 5/7, as a cleanup step. I want to keep "new features" and "api cleanups" separate. That way it's easier to review the changes. Thanks! -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2