linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, Solomon Peachy <solomon@linux-wlan.com>
Subject: Re: [PATCH] Add support for the ESTeem 195E (PPC405EP) SBC
Date: Fri, 31 Jul 2009 10:45:24 +1000	[thread overview]
Message-ID: <20090731004524.GA10243@yookeroo.seuss> (raw)
In-Reply-To: <20090730200848.GF10244@zod.rchland.ibm.com>

On Thu, Jul 30, 2009 at 04:08:49PM -0400, Josh Boyer wrote:
> On Thu, Jul 30, 2009 at 03:45:06PM -0400, Solomon Peachy wrote:
> >On Thu, Jul 30, 2009 at 10:06:30AM -0400, Josh Boyer wrote:
[snip]
> >> >+			UART0: serial@ef600400 {
> >> >+				device_type = "serial";
> >> >+				compatible = "ns16550";
> >> >+				reg = <0xef600400 0x00000008>;
> >> >+				virtual-reg = <0xef600400>;
> >> >+				clock-frequency = <0>; /* Filled in by zImage */
> >> >+				current-speed = <0x9600>;
> >> 
> >> Just a question, but is the baud supposed to be 38400 or 9600?  At first glance
> >> it almost seems like a typo :).
> >
> >It's supposed to be 38400 baud, hence the explicit 0x in front.  (I lost 
> >count of the number of times I saw '38400' listed in various dts 
> >files...)
> 
> Cool.  Just checking.

Um.. except, surely it's clearer to just list 38400 in decimal, rather
than 0x9600 which people are very likely to misread as 9600.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2009-07-31  0:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24 15:21 [PATCH] Add support for the ESTeem 195E (PPC405EP) SBC Solomon Peachy
2009-07-24 15:59 ` Josh Boyer
2009-07-24 16:10   ` Solomon Peachy
2009-07-24 16:45     ` Josh Boyer
2009-07-30 14:06 ` Josh Boyer
2009-07-30 19:45   ` Solomon Peachy
2009-07-30 20:08     ` Josh Boyer
2009-07-31  0:45       ` David Gibson [this message]
2009-07-31  2:38         ` Josh Boyer
2009-08-17 15:13       ` Josh Boyer
2009-08-20 17:45         ` Solomon Peachy
2009-08-20 19:20           ` Josh Boyer
  -- strict thread matches above, loose matches on Subject: below --
2009-07-23 15:21 Solomon Peachy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090731004524.GA10243@yookeroo.seuss \
    --to=david@gibson.dropbear.id.au \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=solomon@linux-wlan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).