From: "M. Mohan Kumar" <mohan@in.ibm.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, Neil Horman <nhorman@redhat.com>,
Simon Horman <horms@verge.net.au>,
kexec@lists.infradead.org, miltonm@bga.com
Subject: Re: [PATCH] Do not inline putprops function
Date: Mon, 3 Aug 2009 11:19:19 +0530 [thread overview]
Message-ID: <20090803054919.GA19594@in.ibm.com> (raw)
In-Reply-To: <1245803263.9237.3.camel@concordia>
On Wed, Jun 24, 2009 at 10:27:43AM +1000, Michael Ellerman wrote:
> On Tue, 2009-06-23 at 09:56 -0400, Neil Horman wrote:
> > On Tue, Jun 23, 2009 at 06:25:34PM +0530, M. Mohan Kumar wrote:
> > >
> > Well it definately looks like removing that variable had some code changes.
> > It'll take some time to match it up to source, but Most interesting I think is
> > the variance in putprops around address f34. Looks like its doing some string
> > maniuplation in a reversed order, using a huge offset. Might be worthwhile to
> > check to see if theres any string overruns in this code.
>
> Yeah I still suspect it's just a bug in the code that's being exposed
> now.
>
Hi,
The same code works with gcc-3.4.
> Mohan, can you try running it under valgrind?
Still I am not able to use valgrind to debug kexec-tools
Regards,
M. Mohan Kumar.
next prev parent reply other threads:[~2009-08-03 5:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 11:34 [PATCH] Do not inline putprops function M. Mohan Kumar
2009-06-17 11:45 ` Simon Horman
2009-06-17 11:59 ` M. Mohan Kumar
2009-06-17 12:26 ` Michael Ellerman
2009-06-17 13:04 ` Neil Horman
2009-06-17 13:34 ` M. Mohan Kumar
2009-06-17 14:05 ` Neil Horman
2009-06-17 14:26 ` M. Mohan Kumar
2009-06-17 14:40 ` Neil Horman
2009-06-23 12:55 ` M. Mohan Kumar
2009-06-23 13:56 ` Neil Horman
2009-06-24 0:27 ` Michael Ellerman
2009-08-03 5:49 ` M. Mohan Kumar [this message]
2009-08-05 16:49 ` M. Mohan Kumar
2009-08-06 14:24 ` Michael Ellerman
2009-08-07 14:35 ` M. Mohan Kumar
2009-08-07 14:54 ` M. Mohan Kumar
2009-08-10 1:51 ` Michael Ellerman
2009-08-10 7:37 ` Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803054919.GA19594@in.ibm.com \
--to=mohan@in.ibm.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=miltonm@bga.com \
--cc=nhorman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).