From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Felix Radensky <felix@embedded-sol.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/85xx: Workaround MPC8536 GPIO 1 errata.
Date: Tue, 11 Aug 2009 19:24:48 +0400 [thread overview]
Message-ID: <20090811152448.GA21956@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <4A818A4C.8060502@embedded-sol.com>
On Tue, Aug 11, 2009 at 06:12:12PM +0300, Felix Radensky wrote:
[...]
> >Plus, this are two reads instead of just one. I think it'll be better
> >to implement mpc8536_gpio_get(), and then do
> >
> >if (of_device_is_compatible(np, ... 8536-gpio-bank ...))
> > gc->get = mpc8536_gpio_get;
> >else
> > gc->get = mpc8xxx_gpio_get;
>
> The reads are from 2 different registers, how do you propose to replace
> them by a single read ?
I didn't propose that, I proposed to not do 2 reads for CPUs that
don't have the errata. ;-)
> I'll implement mpc8572_gpio_get(), suitable for both 8572 and 8536.
Great, thanks!
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
prev parent reply other threads:[~2009-08-11 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 9:04 [PATCH] powerpc/85xx: Workaround MPC8536 GPIO 1 errata Felix Radensky
2009-08-11 13:28 ` Kumar Gala
2009-08-11 13:44 ` Anton Vorontsov
2009-08-11 13:57 ` Kumar Gala
2009-08-11 15:12 ` Felix Radensky
2009-08-11 15:24 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090811152448.GA21956@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=felix@embedded-sol.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).