linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	galak@kernel.crashing.orga
Subject: Re: [PATCH -v2 0/7] powerpc: use asm-generic/dma-mapping-common.h
Date: Thu, 13 Aug 2009 09:41:31 +0200	[thread overview]
Message-ID: <20090813074131.GH12143@elte.hu> (raw)
In-Reply-To: <20090813160625B.fujita.tomonori@lab.ntt.co.jp>


* FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:

> On Thu, 13 Aug 2009 15:48:42 +1000
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> 
> > On Wed, 2009-08-05 at 14:08 +0900, FUJITA Tomonori wrote:
> > 
> > > The above swiotlb patchset was merged in -tip so I think that merging
> > > this patchset via -tip too is the easiest way to handle this patchset.
> > > 
> > > The patchset also is available via a git tree:
> > > 
> > > git://git.kernel.org/pub/scm/linux/kernel/git/tomo/linux-2.6-misc.git powerpc
> > 
> > Hi !
> > 
> > While I generally agree here with the patches, I'm not sure it should be
> > merged via -tip since it mostly touches arch/powerpc files (and I need
> > to review it a bit more carefully, hopefully you'll have Ack's hitting
> > your mailbox later today).
> 
> Thanks!
> 
> This patchset depends on my swiotlb cleanup patchset:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/tomo/linux-2.6-misc.git swiotlb
> 
> http://marc.info/?l=linux-ia64&m=124718816520156&w=2
> 
> My swiotlb cleanup patchset has been in -tip. It might be easier 
> to merge both the swiotlb patchset and this patchset in powerpc 
> tree?

Ben, what's your preference? I waited for your reaction with these 
bits, i.e. they are not in tip:core/iommu yet.

One variant would be what Fujita suggested: you could pull 
core/iommu as a basis (it's a well-tested, problem-free tree at the 
moment, with no big risky items), and then pull/apply the powerpc 
specific bits from Fujita.

A second variant would be that we could pull these bits into 
core/iommu ... albeit you are right that the PowerPC tree is much 
better at testing PowerPC patches.

A third variant would be to wait with these bits until the swiotlb 
bits in core/iommu hit upstream. This would increase patch latency.

Any of these variants is good to me. What Fujita suggests seems to 
be the best to me: #1 gets us the most testing and the lowest 
latency - at the cost of tree dependency. We wont rebase core/iommu.

[ We've got three good tree properties: "tree independence",
  "good testing", "low patch latency", but we cannot have all
  three at once, we must pick two of them ;-) ]

	Ingo

  reply	other threads:[~2009-08-13  8:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05  5:08 [PATCH -v2 0/7] powerpc: use asm-generic/dma-mapping-common.h FUJITA Tomonori
2009-08-05  5:08 ` [PATCH -v2 1/7] powerpc: remove addr_needs_map in struct dma_mapping_ops FUJITA Tomonori
2009-08-05  5:08 ` [PATCH -v2 2/7] powerpc: remove swiotlb_pci_dma_ops FUJITA Tomonori
2009-08-05  5:08 ` [PATCH -v2 3/7] add set_dma_mask hook to struct dma_map_ops FUJITA Tomonori
2009-08-05  5:08 ` [PATCH -v2 4/7] powerpc: use dma_map_ops struct FUJITA Tomonori
2009-08-05  5:08 ` [PATCH -v2 5/7] powerpc: use asm-generic/dma-mapping-common.h FUJITA Tomonori
2009-08-05  5:08 ` [PATCH -v2 6/7] powerpc: handle SWIOTLB mapping error properly FUJITA Tomonori
2009-08-05  5:08 ` [PATCH -v2 7/7] powerpc: add CONFIG_DMA_API_DEBUG support FUJITA Tomonori
2009-08-13  5:48 ` [PATCH -v2 0/7] powerpc: use asm-generic/dma-mapping-common.h Benjamin Herrenschmidt
2009-08-13  6:51   ` Benjamin Herrenschmidt
2009-08-13  7:11     ` Takashi Iwai
2009-08-13  8:07       ` Benjamin Herrenschmidt
2009-08-13  8:11         ` Takashi Iwai
2009-08-13  7:07   ` FUJITA Tomonori
2009-08-13  7:41     ` Ingo Molnar [this message]
2009-08-13  8:09       ` Benjamin Herrenschmidt
2009-08-13  8:55         ` Ingo Molnar
2009-08-13 10:38           ` Benjamin Herrenschmidt
2009-08-13 13:31             ` Kumar Gala
2009-08-27  3:12           ` Benjamin Herrenschmidt
2009-08-27  3:17             ` Benjamin Herrenschmidt
2009-08-27  7:22               ` Ingo Molnar
2009-08-27  7:36                 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090813074131.GH12143@elte.hu \
    --to=mingo@elte.hu \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=galak@kernel.crashing.orga \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).