From: David Miller <davem@davemloft.net>
To: john.linn@xilinx.com
Cc: michal.simek@petalogix.com, netdev@vger.kernel.org,
sadanan@xilinx.com, linuxppc-dev@ozlabs.org, jgarzik@pobox.com,
john.williams@petalogix.com
Subject: Re: [PATCH] net: add Xilinx emac lite device driver
Date: Tue, 18 Aug 2009 23:28:15 -0700 (PDT) [thread overview]
Message-ID: <20090818.232815.73515404.davem@davemloft.net> (raw)
In-Reply-To: <20090818153047.48E42ED8051@mail66-dub.bigfish.com>
From: John Linn <john.linn@xilinx.com>
Date: Tue, 18 Aug 2009 09:30:41 -0600
> @@ -1926,6 +1926,11 @@ config ATL2
> To compile this driver as a module, choose M here. The module
> will be called atl2.
>
> +config XILINX_EMACLITE
> + tristate "Xilinx 10/100 Ethernet Lite support"
> + help
> + This driver supports the 10/100 Ethernet Lite from Xilinx.
> +
> source "drivers/net/fs_enet/Kconfig"
>
> endif # NET_ETHERNET
You can't unconditionally enable this driver everywhere.
It depends upon things like openfirmware support, etc.
so the driver will fail to link if the architecture doesn't
have those support routines.
Please fix this up, thanks.
next prev parent reply other threads:[~2009-08-19 6:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 15:30 [PATCH] net: add Xilinx emac lite device driver John Linn
2009-08-18 21:04 ` Stephen Hemminger
2009-08-19 7:20 ` John Linn
2009-08-19 6:28 ` David Miller [this message]
2009-08-19 7:13 ` John Linn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090818.232815.73515404.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=john.linn@xilinx.com \
--cc=john.williams@petalogix.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michal.simek@petalogix.com \
--cc=netdev@vger.kernel.org \
--cc=sadanan@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).