From: Christoph Hellwig <hch@lst.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, kyle@mcmartin.ca,
linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org,
Paul Mackerras <paulus@samba.org>,
ink@jurassic.park.msu.ru, rth@twiddle.net
Subject: Re: linux-next: powerpc tree build warning
Date: Mon, 24 Aug 2009 03:01:53 +0200 [thread overview]
Message-ID: <20090824010153.GB21533@lst.de> (raw)
In-Reply-To: <20090824102256.3e8d69b6.sfr@canb.auug.org.au>
On Mon, Aug 24, 2009 at 10:22:56AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next build (powerpc ppc64_defconfig) produced this warning:
>
> kernel/time/tick-sched.c: In function 'tick_nohz_stop_sched_tick':
> kernel/time/tick-sched.c:261: warning: format '%02x' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
>
> Introduced by commit 6826a57d1abc8ac9f59b24f1a008554c6560a995 ("powerpc:
> Switch to asm-generic/hardirq.h") which changed
> irq_cpustat_t::__softirq_pending from "unsigned int" to "unsigned long"
> on powerpc.
Hah, that's an interesting one. In currently mainline the following
architectures have it as unsigned long:
alpha, parisc and blackfin/microblaze via asm-generic
and all others have it as unsigned int. For blackfin and microblaze
it obviously doesn't matter, so the question is why alpha and parisc
have it as usinged long. We defintively should standardize on one,
and unless alpha and parisc have good reasons for needing a long
value that would be unsigned int.
next prev parent reply other threads:[~2009-08-24 1:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 0:22 linux-next: powerpc tree build warning Stephen Rothwell
2009-08-24 1:01 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-06-11 1:39 Stephen Rothwell
2009-06-11 3:14 ` Benjamin Herrenschmidt
2009-05-22 1:28 Stephen Rothwell
2009-05-22 1:11 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090824010153.GB21533@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=ink@jurassic.park.msu.ru \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=rth@twiddle.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).