From: Christoph Hellwig <hch@lst.de>
To: Becky Bruce <beckyb@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Change archdata dma_data type to dma_addr_t
Date: Mon, 24 Aug 2009 21:48:00 +0200 [thread overview]
Message-ID: <20090824194800.GA13503@lst.de> (raw)
In-Reply-To: <1251130634-15093-1-git-send-email-beckyb@kernel.crashing.org>
On Mon, Aug 24, 2009 at 11:17:14AM -0500, Becky Bruce wrote:
> Previously, this was specified as a void *, but that's not
> large enough on 32-bit systems with 36-bit physical
> addressing support. Change the type to dma_addr_t so it
> will scale based on the size of a dma address.
This looks extreml ugly to me. It seems like the typical use is to
store a pointer to a structure. So what about making the direct
dma case follow that general scheme instead?
E.g. declare a
struct direct_dma_data {
dma_addr_t direct_dma_offset;
};
and have one normal instace of it, and one per weird cell device.
next prev parent reply other threads:[~2009-08-24 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 16:17 [PATCH] powerpc: Change archdata dma_data type to dma_addr_t Becky Bruce
2009-08-24 19:48 ` Christoph Hellwig [this message]
2009-08-26 12:29 ` Benjamin Herrenschmidt
2009-08-26 14:08 ` Michael Ellerman
2009-08-26 20:20 ` Becky Bruce
2009-08-27 0:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090824194800.GA13503@lst.de \
--to=hch@lst.de \
--cc=beckyb@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).