From: Grant Likely <grant.likely@secretlab.ca>
To: linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Cc: Roderick Colenbrander <thunderbird2k@gmail.com>
Subject: [PATCH] powerpc: Fix i8259 interrupt driver kernel crash on ML510
Date: Thu, 03 Sep 2009 09:57:23 -0600 [thread overview]
Message-ID: <20090903155208.18009.73841.stgit@localhost.localdomain> (raw)
From: Roderick Colenbrander <thunderbird2k@gmail.com>
This patch fixes a null pointer exception caused by removal of
'ack()' for level interrupts in the Xilinx interrupt driver. A recent
change to the xilinx interrupt controller removed the ack hook for
level irqs.
Signed-off-by: Roderick Colenbrander <thunderbird2k@gmail.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
Hi Ben & Linus,
This is a last minute bug fix must go into 2.6.31. This patch
is needed to prevent a kernel panic on Xilinx ml510 boards.
I've also pushed the patch out to my git tree if you'd prefer to pull:
The following changes since commit 326ba5010a5429a5a528b268b36a5900d4ab0eba:
Linus Torvalds (1):
Linux 2.6.31-rc8
are available in the git repository at:
git://git.secretlab.ca/git/linux-2.6 merge
Roderick Colenbrander (1):
powerpc: Fix i8259 interrupt driver kernel crash on ML510
arch/powerpc/sysdev/xilinx_intc.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/sysdev/xilinx_intc.c b/arch/powerpc/sysdev/xilinx_intc.c
index 3ee1fd3..40edad5 100644
--- a/arch/powerpc/sysdev/xilinx_intc.c
+++ b/arch/powerpc/sysdev/xilinx_intc.c
@@ -234,7 +234,6 @@ static void xilinx_i8259_cascade(unsigned int irq, struct irq_desc *desc)
generic_handle_irq(cascade_irq);
/* Let xilinx_intc end the interrupt */
- desc->chip->ack(irq);
desc->chip->unmask(irq);
}
next reply other threads:[~2009-09-03 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 15:57 Grant Likely [this message]
2009-09-03 22:44 ` [PATCH] powerpc: Fix i8259 interrupt driver kernel crash on ML510 Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090903155208.18009.73841.stgit@localhost.localdomain \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=thunderbird2k@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).