From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yx0-f197.google.com (mail-yx0-f197.google.com [209.85.210.197]) by ozlabs.org (Postfix) with ESMTP id A9880B7B6B for ; Thu, 17 Sep 2009 11:44:35 +1000 (EST) Received: by yxe35 with SMTP id 35so18216438yxe.2 for ; Wed, 16 Sep 2009 18:44:33 -0700 (PDT) Sender: Josh Boyer Date: Wed, 16 Sep 2009 21:44:18 -0400 From: Josh Boyer To: Benjamin Herrenschmidt Subject: Re: RFC: delete UART current-speed from 4xx DTS? Message-ID: <20090917014418.GA4536@hansolo.jdub.homelinux.org> References: <20090915143135.GA7015@windriver.com> <20090915153220.GG12372@zod.rchland.ibm.com> <1253051047.8375.232.camel@pasglop> <20090916131943.GA14261@zod.rchland.ibm.com> <1253136666.8375.288.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1253136666.8375.288.camel@pasglop> Cc: Paul Gortmaker , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Sep 17, 2009 at 07:31:06AM +1000, Benjamin Herrenschmidt wrote: > >> Ok, so I think that is related to what I originally hit. >> >> I played around with removing the current-speed property on canyonlands today, >> and noticed that I would get no console output at all unless I specified a >> baudrate with console=ttyS0,115200. That was sort of contrary to what I found >> with bamboo, so I diffed the configs to see why. Bamboo has udbg enabled and >> hence has legacy_serial builtin, whereas canyonlands just has of_serial. >> >> So on boards where of_serial is the only serial driver, we need either an >> accurate current-speed property, or a specific baudrate on the command line. >> That makes a bit more tenuous to remove the properties entirely, because if >> people disable udbg and are relying on that behavior they get no more console >> output. Need to think on that a bit I guess. >> >> Alternatively, we could try patching of_serial.c to do the baudrate probe >> as well. > >Well, I've always wondered why we just don't put the probe in the 8250 >driver... I proposed it on the list a while back and there was no Probably because anything to do with the serial drivers or tty layer scares the living hell out of people other than Alan and Andrew. And I sometimes think even Andrew is faking... ;) >serious objection, but then forgot about it :-) > >We should do it, and check if the result is sane (looks like a standard >speed). If it is, we should then just used it. Sounds sane enough. I'm hoping to get some time in the next few days to poke at this. josh