linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* drivers/mfd/ab3100-core.c
@ 2009-09-18  0:20 Andrew Morton
  2009-09-18  1:22 ` drivers/mfd/ab3100-core.c Anton Vorontsov
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2009-09-18  0:20 UTC (permalink / raw)
  To: Samuel Ortiz, Benjamin Herrenschmidt; +Cc: linuxppc-dev

This:

static const struct ab3100_init_setting __initdata
ab3100_init_settings[] = {

causes this:

drivers/mfd/ab3100-core.c:651: error: ab3100_init_settings causes a section type conflict

on ppc64.

I keep forgetting why.  Did MFD do something wrong or is powerpc borked
or did my compiler version expire?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: drivers/mfd/ab3100-core.c
  2009-09-18  0:20 drivers/mfd/ab3100-core.c Andrew Morton
@ 2009-09-18  1:22 ` Anton Vorontsov
  2009-09-18  1:30   ` drivers/mfd/ab3100-core.c Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Anton Vorontsov @ 2009-09-18  1:22 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Samuel Ortiz, linuxppc-dev

On Thu, Sep 17, 2009 at 05:20:58PM -0700, Andrew Morton wrote:
> This:
> 
> static const struct ab3100_init_setting __initdata
> ab3100_init_settings[] = {

Looks like it should be __initconst, otherwise it's ambiguous.

> causes this:
> 
> drivers/mfd/ab3100-core.c:651: error: ab3100_init_settings causes a section type conflict
> 
> on ppc64.
> 
> I keep forgetting why.  Did MFD do something wrong or is powerpc borked
> or did my compiler version expire?

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: drivers/mfd/ab3100-core.c
  2009-09-18  1:22 ` drivers/mfd/ab3100-core.c Anton Vorontsov
@ 2009-09-18  1:30   ` Andrew Morton
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2009-09-18  1:30 UTC (permalink / raw)
  To: avorontsov; +Cc: sameo, linuxppc-dev

On Fri, 18 Sep 2009 05:22:13 +0400
Anton Vorontsov <avorontsov@ru.mvista.com> wrote:

> On Thu, Sep 17, 2009 at 05:20:58PM -0700, Andrew Morton wrote:
> > This:
> > 
> > static const struct ab3100_init_setting __initdata
> > ab3100_init_settings[] = {
> 
> Looks like it should be __initconst, otherwise it's ambiguous.
> 
> > causes this:
> > 
> > drivers/mfd/ab3100-core.c:651: error: ab3100_init_settings causes a section type conflict
> > 
> > on ppc64.
> > 
> > I keep forgetting why.  Did MFD do something wrong or is powerpc borked
> > or did my compiler version expire?
> 

doh, OK, I forgot about initconst.  I'll try it..

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-09-18  1:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-18  0:20 drivers/mfd/ab3100-core.c Andrew Morton
2009-09-18  1:22 ` drivers/mfd/ab3100-core.c Anton Vorontsov
2009-09-18  1:30   ` drivers/mfd/ab3100-core.c Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).