From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from SG2EHSOBE005.bigfish.com (sg2ehsobe005.messaging.microsoft.com [207.46.51.79]) by ozlabs.org (Postfix) with ESMTP id 903B4B7B74 for ; Wed, 23 Sep 2009 02:56:36 +1000 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Subject: RE: [PATCH] net: xilinx_emaclite: Fix problem with first incoming packet Date: Tue, 22 Sep 2009 10:56:27 -0600 In-Reply-To: References: From: John Linn To: "Grant Likely" Message-ID: <20090922165612.584554A8052@mail195-sin.bigfish.com> Cc: Michal Simek , linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, Sadanand Mutyala , davem@davemloft.net List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Thanks Grant, I wondered about that myself. > -----Original Message----- > From: glikely@secretlab.ca [mailto:glikely@secretlab.ca] On Behalf Of Gra= nt Likely > Sent: Tuesday, September 22, 2009 10:54 AM > To: John Linn > Cc: netdev@vger.kernel.org; davem@davemloft.net; linuxppc-dev@ozlabs.org;= jwboyer@linux.vnet.ibm.com; > Sadanand Mutyala; Michal Simek > Subject: Re: [PATCH] net: xilinx_emaclite: Fix problem with first incomin= g packet > = > On Tue, Sep 22, 2009 at 8:24 AM, John Linn wrote: > > From: Michal Simek > > > > You can't ping the board or connect to it unless you send > > any packet out from board. > > > > Tested-by: John Williams > > Signed-off-by: Michal Simek > > Acked-by: John Linn > = > John, Since this patch is being *sent* by you, then you should use a > "signed-off-by" tag instead because it actually passed through your > hands. > = > Oh, and: > Acked-by: Grant Likely > = > > --- > > =A0drivers/net/xilinx_emaclite.c | =A0 =A07 ++----- > > =A01 files changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/net/xilinx_emaclite.c b/drivers/net/xilinx_emaclit= e.c > > index dc22782..83a044d 100644 > > --- a/drivers/net/xilinx_emaclite.c > > +++ b/drivers/net/xilinx_emaclite.c > > @@ -134,18 +134,15 @@ static void xemaclite_enable_interrupts(struct ne= t_local *drvdata) > > =A0 =A0 =A0 =A0} > > > > =A0 =A0 =A0 =A0/* Enable the Rx interrupts for the first buffer */ > > - =A0 =A0 =A0 reg_data =3D in_be32(drvdata->base_addr + XEL_RSR_OFFSET)= ; > > =A0 =A0 =A0 =A0out_be32(drvdata->base_addr + XEL_RSR_OFFSET, > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0reg_data | XEL_RSR_RECV_IE_MASK); > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0XEL_RSR_RECV_IE_MASK); > > > > =A0 =A0 =A0 =A0/* Enable the Rx interrupts for the second Buffer if > > =A0 =A0 =A0 =A0 * configured in HW */ > > =A0 =A0 =A0 =A0if (drvdata->rx_ping_pong !=3D 0) { > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg_data =3D in_be32(drvdata->base_addr += XEL_BUFFER_OFFSET + > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0XE= L_RSR_OFFSET); > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0out_be32(drvdata->base_addr + XEL_BUFFER= _OFFSET + > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 XEL_RSR_OFFSET, > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0reg_data | XEL_RSR_REC= V_IE_MASK); > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0XEL_RSR_RECV_IE_MASK);= > > =A0 =A0 =A0 =A0} > > > > =A0 =A0 =A0 =A0/* Enable the Global Interrupt Enable */ > > -- > > 1.6.2.1 > > > > > > > > This email and any attachments are intended for the sole use of the nam= ed recipient(s) and > contain(s) confidential information that may be proprietary, privileged o= r copyrighted under > applicable law. If you are not the intended recipient, do not read, copy,= or forward this email > message or any attachments. Delete this email message and any attachments= immediately. > > > > > > > = > = > = > -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. This email and any attachments are intended for the sole use of the named r= ecipient(s) and contain(s) confidential information that may be proprietary= , privileged or copyrighted under applicable law. If you are not the intend= ed recipient, do not read, copy, or forward this email message or any attac= hments. Delete this email message and any attachments immediately.