Re: [PATCH 3/6] P2020DS: Fixup sdhc to use PIO mode

[Anton Vorontsov <avorontsov@ru.mvista.com>]

On Wed, Sep 23, 2009 at 05:08:09PM +0800, Gao Guanhua wrote:
> The SDHC can not work on DMA mode because of the hardware bug,
> so we set a broken dma flag and use PIO mode. This patch applies
> to Rev1.0.

Signed-off-by line is missing (in all patches).

> ---
>  arch/powerpc/boot/dts/p2020ds.dts |    1 +
>  drivers/mmc/host/sdhci-of.c       |    3 +++
>  2 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/p2020ds.dts b/arch/powerpc/boot/dts/p2020ds.dts
> index be449ba..574ad4f 100644
> --- a/arch/powerpc/boot/dts/p2020ds.dts
> +++ b/arch/powerpc/boot/dts/p2020ds.dts
> @@ -459,6 +459,7 @@
>  			reg = <0x2e000 0x1000>;
>  			interrupts = <72 0x2>;
>  			interrupt-parent = <&mpic>;
> +			fsl,sdhci-dma-broken;

You might want to update
Documentation/powerpc/dts-bindings/fsl/esdhc.txt

>  			clock-frequency = <0>;
>  		};
>  
> diff --git a/drivers/mmc/host/sdhci-of.c b/drivers/mmc/host/sdhci-of.c
> index 01ab916..5879483 100644
> --- a/drivers/mmc/host/sdhci-of.c
> +++ b/drivers/mmc/host/sdhci-of.c
> @@ -270,6 +270,9 @@ static int __devinit sdhci_of_probe(struct of_device *ofdev,
>  	if (sdhci_of_wp_inverted(np))
>  		host->quirks |= SDHCI_QUIRK_INVERTED_WRITE_PROTECT;
>  
> +	if (of_get_property(np, "fsl,sdhci-dma-broken", NULL))
> +		host->quirks |= SDHCI_QUIRK_BROKEN_DMA;
> +
>  	clk = of_get_property(np, "clock-frequency", &size);
>  	if (clk && size == sizeof(*clk) && *clk)
>  		of_host->clock = *clk;
> -- 
> 1.6.4

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2