From: Stefan Roese <sr@denx.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH/RFC] powerpc: Fix decrementer setup on 1GHz boards
Date: Fri, 9 Oct 2009 07:28:28 +0200 [thread overview]
Message-ID: <200910090728.28870.sr@denx.de> (raw)
In-Reply-To: <1255032776.2146.7.camel@pasglop>
On Thursday 08 October 2009 22:12:56 Benjamin Herrenschmidt wrote:
> On Thu, 2009-10-08 at 16:49 +0200, Stefan Roese wrote:
> > We noticed that recent kernels didn't boot on our 1GHz Canyonlands
460EX
> > boards anymore. As it seems, patch 8d165db1 [powerpc: Improve
> > decrementer accuracy] introduced this problem. The routine div_sc()
> > overflows with shift = 32 resulting in this incorrect setup:
> >
> > time_init: decrementer frequency = 1000.000012 MHz
> > time_init: processor frequency = 1000.000012 MHz
> > clocksource: timebase mult[400000] shift[22] registered
> > clockevent: decrementer mult[33] shift[32] cpu[0]
> >
> > This patch now introduces a local div_dc64() version of this function
> > so that this overflow doesn't happen anymore.
>
> Ugh ? We never expected that the decrementer would be ticking that fast.
> This is too fast actually. Somebody at AMCC must be told to stick a
> divider in front of the timebase when reaching such frequencies.
As Josh already pointed out on IRC, the source of timebase can be either
the CPU clock or an external provided clock. We always used the CPU clock
as timebase source till now.
I looked at switching to external clock on Canyonlands, but this doesn't
look promising. The external timer clock here is the output of the RTC
M41T62, which is a max of 32768 Hz. Enabling this clock also has the
disadvantage to drain the RTC battery quickly. That's why this clock output
is currently disabled per default.
So how could we solve this issue now? Apply my current patch? Any other
suggestions?
Thanks.
Cheers,
Stefan
next prev parent reply other threads:[~2009-10-09 5:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 14:49 [PATCH/RFC] powerpc: Fix decrementer setup on 1GHz boards Stefan Roese
2009-10-08 20:12 ` Benjamin Herrenschmidt
2009-10-09 5:28 ` Stefan Roese [this message]
2009-10-09 6:27 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910090728.28870.sr@denx.de \
--to=sr@denx.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).