From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp05.in.ibm.com (e28smtp05.in.ibm.com [59.145.155.5]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e28smtp05.in.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 39762B6F2B for ; Wed, 14 Oct 2009 17:24:30 +1100 (EST) Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by e28smtp05.in.ibm.com (8.14.3/8.13.1) with ESMTP id n9E6OEno025104 for ; Wed, 14 Oct 2009 11:54:14 +0530 Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n9E6OEe52400450 for ; Wed, 14 Oct 2009 11:54:14 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id n9E6ODC6005037 for ; Wed, 14 Oct 2009 17:24:14 +1100 Date: Wed, 14 Oct 2009 11:54:12 +0530 From: Arun R Bharadwaj To: Balbir Singh Subject: Re: [v8 PATCH 1/8]: cpuidle: cleanup drivers/cpuidle/cpuidle.c Message-ID: <20091014062412.GB8605@linux.vnet.ibm.com> References: <20091008094828.GA20595@linux.vnet.ibm.com> <20091008094942.GB20595@linux.vnet.ibm.com> <20091012113602.GC3007@balbir.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <20091012113602.GC3007@balbir.in.ibm.com> Cc: linux-arch@vger.kernel.org, Peter Zijlstra , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Arun Bharadwaj , Ingo Molnar , linuxppc-dev@lists.ozlabs.org, Arjan van de Ven Reply-To: arun@linux.vnet.ibm.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Balbir Singh [2009-10-12 17:06:02]: > * Arun R B [2009-10-08 15:19:42]: > > > * Arun R Bharadwaj [2009-10-08 15:18:28]: > > > > This patch cleans up drivers/cpuidle/cpuidle.c > > Earlier cpuidle assumed pm_idle as the default idle loop. Break that > > assumption and make it more generic. cpuidle_idle_call() which is the > > main idle loop of cpuidle is to be called by architectures which have > > registered to cpuidle. > > > > Remove routines cpuidle_install/uninstall_idle_handler() which are not > > needed anymore. > > > > > > [snip] > > /** > > - * cpuidle_install_idle_handler - installs the cpuidle idle loop handler > > - */ > > -void cpuidle_install_idle_handler(void) > > -{ > > - if (enabled_devices && (pm_idle != cpuidle_idle_call)) { > > - /* Make sure all changes finished before we switch to new idle */ > > - smp_wmb(); > > - pm_idle = cpuidle_idle_call; > > - } > > -} > > - > > -/** > > - * cpuidle_uninstall_idle_handler - uninstalls the cpuidle idle loop handler > > - */ > > -void cpuidle_uninstall_idle_handler(void) > > -{ > > - if (enabled_devices && pm_idle_old && (pm_idle != pm_idle_old)) { > > - pm_idle = pm_idle_old; > > - cpuidle_kick_cpus(); > > - } > > -} > > - > > I see the routines above being called in from > cpuidle_pause/resume_and_lock/unlock below and they are entries from > ACPI on ACPI_PROCESSOR_NOTIFY_POWER and from the hotplug path, could > you test them to make sure they are not broken. We also seem to be > missing a cpuidle_kick_cpus() in cpuidle_pause_and_lock() > > [snip] > Hi Balbir, yes, we definitely need a cpuidle_kick_cpus() in cpuidle_pause_and_lock() since this is used while disabling the cpuidle_device and the cpus need to be kicked out of the idle states. I will test this modified code and see if it breaks hotplug. thanks, arun > -- > Balbir