* [PATCH 1/3] powerpc: perf_event: Cleanup copy_page output by hiding setup symbol
@ 2009-10-18 11:23 Anton Blanchard
2009-10-18 11:24 ` [PATCH 2/3] powerpc: perf_event: Cleanup output by adding symbols Anton Blanchard
0 siblings, 1 reply; 6+ messages in thread
From: Anton Blanchard @ 2009-10-18 11:23 UTC (permalink / raw)
To: benh; +Cc: linuxppc-dev, mingo, paulus, a.p.zijlstra
A lot of hits in "setup" doesn't make much sense, so hide this symbol and
allow all the hits to end up in copy_4k_page.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
Index: linux.trees.git/arch/powerpc/lib/copypage_64.S
===================================================================
--- linux.trees.git.orig/arch/powerpc/lib/copypage_64.S 2009-07-06 10:13:56.000000000 +1000
+++ linux.trees.git/arch/powerpc/lib/copypage_64.S 2009-07-06 10:13:57.000000000 +1000
@@ -26,11 +26,11 @@
srd r8,r5,r11
mtctr r8
-setup:
+.Lsetup:
dcbt r9,r4
dcbz r9,r3
add r9,r9,r12
- bdnz setup
+ bdnz .Lsetup
END_FTR_SECTION_IFSET(CPU_FTR_CP_USE_DCBTZ)
addi r3,r3,-8
srdi r8,r5,7 /* page is copied in 128 byte strides */
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/3] powerpc: perf_event: Cleanup output by adding symbols
2009-10-18 11:23 [PATCH 1/3] powerpc: perf_event: Cleanup copy_page output by hiding setup symbol Anton Blanchard
@ 2009-10-18 11:24 ` Anton Blanchard
2009-10-18 11:24 ` [PATCH 3/3] powerpc: perf_event: Hide iseries_check_pending_irqs Anton Blanchard
0 siblings, 1 reply; 6+ messages in thread
From: Anton Blanchard @ 2009-10-18 11:24 UTC (permalink / raw)
To: benh; +Cc: linuxppc-dev, mingo, paulus, a.p.zijlstra
Add some dummy symbols for the branches at 0xf00, 0xf20 and 0xf40,
otherwise hits end up in trap_0e which is confusing to the user.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
Index: linux.trees.git/arch/powerpc/kernel/exceptions-64s.S
===================================================================
--- linux.trees.git.orig/arch/powerpc/kernel/exceptions-64s.S 2009-07-06 10:13:56.000000000 +1000
+++ linux.trees.git/arch/powerpc/kernel/exceptions-64s.S 2009-07-06 10:13:57.000000000 +1000
@@ -185,12 +185,15 @@
* prolog code of the PerformanceMonitor one. A little
* trickery is thus necessary
*/
+performance_monitor_pSeries_1:
. = 0xf00
b performance_monitor_pSeries
+altivec_unavailable_pSeries_1:
. = 0xf20
b altivec_unavailable_pSeries
+vsx_unavailable_pSeries_1:
. = 0xf40
b vsx_unavailable_pSeries
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] powerpc: perf_event: Hide iseries_check_pending_irqs
2009-10-18 11:24 ` [PATCH 2/3] powerpc: perf_event: Cleanup output by adding symbols Anton Blanchard
@ 2009-10-18 11:24 ` Anton Blanchard
2009-10-19 7:23 ` Ingo Molnar
0 siblings, 1 reply; 6+ messages in thread
From: Anton Blanchard @ 2009-10-18 11:24 UTC (permalink / raw)
To: benh; +Cc: linuxppc-dev, mingo, paulus, a.p.zijlstra
If CONFIG_PPC_ISERIES isn't defined we end up with iseries_check_pending_irqs
and do_work at the same address. perf ends up picking
iseries_check_pending_irqs which creates confusing backtraces. Hide it.
Signed-off-by: Anton Blanchard <anton@samba.org>
--
Index: linux.trees.git/arch/powerpc/kernel/entry_64.S
===================================================================
--- linux.trees.git.orig/arch/powerpc/kernel/entry_64.S 2009-10-16 11:06:10.000000000 +1100
+++ linux.trees.git/arch/powerpc/kernel/entry_64.S 2009-10-16 11:06:28.000000000 +1100
@@ -551,7 +551,7 @@ restore:
BEGIN_FW_FTR_SECTION
ld r5,SOFTE(r1)
FW_FTR_SECTION_ELSE
- b iseries_check_pending_irqs
+ b .Liseries_check_pending_irqs
ALT_FW_FTR_SECTION_END_IFCLR(FW_FEATURE_ISERIES)
2:
TRACE_AND_RESTORE_IRQ(r5);
@@ -623,7 +623,7 @@ ALT_FW_FTR_SECTION_END_IFCLR(FW_FEATURE_
#endif /* CONFIG_PPC_BOOK3E */
-iseries_check_pending_irqs:
+.Liseries_check_pending_irqs:
#ifdef CONFIG_PPC_ISERIES
ld r5,SOFTE(r1)
cmpdi 0,r5,0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] powerpc: perf_event: Hide iseries_check_pending_irqs
2009-10-18 11:24 ` [PATCH 3/3] powerpc: perf_event: Hide iseries_check_pending_irqs Anton Blanchard
@ 2009-10-19 7:23 ` Ingo Molnar
2009-10-20 3:50 ` Anton Blanchard
0 siblings, 1 reply; 6+ messages in thread
From: Ingo Molnar @ 2009-10-19 7:23 UTC (permalink / raw)
To: Anton Blanchard; +Cc: paulus, a.p.zijlstra, linuxppc-dev
* Anton Blanchard <anton@samba.org> wrote:
> If CONFIG_PPC_ISERIES isn't defined we end up with iseries_check_pending_irqs
> and do_work at the same address. perf ends up picking
> iseries_check_pending_irqs which creates confusing backtraces. Hide it.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
Just to confirm - these 3 symbol fixes are for the PowerPC tree, not for
the perf events tree, right? There's nothing perf specific about the
fixes - kgdb, systemtap and other debugging/instrumentation frameworks
will benefit from more precise symbol generation too.
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] powerpc: perf_event: Hide iseries_check_pending_irqs
2009-10-19 7:23 ` Ingo Molnar
@ 2009-10-20 3:50 ` Anton Blanchard
2009-10-20 4:12 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 6+ messages in thread
From: Anton Blanchard @ 2009-10-20 3:50 UTC (permalink / raw)
To: Ingo Molnar; +Cc: paulus, a.p.zijlstra, linuxppc-dev
Hi Ingo,
> Just to confirm - these 3 symbol fixes are for the PowerPC tree, not for
> the perf events tree, right? There's nothing perf specific about the
> fixes - kgdb, systemtap and other debugging/instrumentation frameworks
> will benefit from more precise symbol generation too.
Yeah, while they were written to fix perf backtrace issues they are
definitely not perf specific. Hopefully Ben will queue them up in his
tree for the next merge window :)
Anton
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] powerpc: perf_event: Hide iseries_check_pending_irqs
2009-10-20 3:50 ` Anton Blanchard
@ 2009-10-20 4:12 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2009-10-20 4:12 UTC (permalink / raw)
To: Anton Blanchard; +Cc: linuxppc-dev, Ingo Molnar, paulus, a.p.zijlstra
On Tue, 2009-10-20 at 14:50 +1100, Anton Blanchard wrote:
> Hi Ingo,
>
> > Just to confirm - these 3 symbol fixes are for the PowerPC tree, not for
> > the perf events tree, right? There's nothing perf specific about the
> > fixes - kgdb, systemtap and other debugging/instrumentation frameworks
> > will benefit from more precise symbol generation too.
>
> Yeah, while they were written to fix perf backtrace issues they are
> definitely not perf specific. Hopefully Ben will queue them up in his
> tree for the next merge window :)
Right, I'm overdue for a powerpc-next but with some family issues last
couple of week and KS/JLS this week, it' a bit hard :-)
Ben.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-10-20 4:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-18 11:23 [PATCH 1/3] powerpc: perf_event: Cleanup copy_page output by hiding setup symbol Anton Blanchard
2009-10-18 11:24 ` [PATCH 2/3] powerpc: perf_event: Cleanup output by adding symbols Anton Blanchard
2009-10-18 11:24 ` [PATCH 3/3] powerpc: perf_event: Hide iseries_check_pending_irqs Anton Blanchard
2009-10-19 7:23 ` Ingo Molnar
2009-10-20 3:50 ` Anton Blanchard
2009-10-20 4:12 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).