From: Anton Blanchard <anton@samba.org>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, mingo@elte.hu, paulus@samba.org,
a.p.zijlstra@chello.nl
Subject: [PATCH 3/3] powerpc: perf_event: Hide iseries_check_pending_irqs
Date: Sun, 18 Oct 2009 22:24:29 +1100 [thread overview]
Message-ID: <20091018112429.GP4808@kryten> (raw)
In-Reply-To: <20091018112406.GO4808@kryten>
If CONFIG_PPC_ISERIES isn't defined we end up with iseries_check_pending_irqs
and do_work at the same address. perf ends up picking
iseries_check_pending_irqs which creates confusing backtraces. Hide it.
Signed-off-by: Anton Blanchard <anton@samba.org>
--
Index: linux.trees.git/arch/powerpc/kernel/entry_64.S
===================================================================
--- linux.trees.git.orig/arch/powerpc/kernel/entry_64.S 2009-10-16 11:06:10.000000000 +1100
+++ linux.trees.git/arch/powerpc/kernel/entry_64.S 2009-10-16 11:06:28.000000000 +1100
@@ -551,7 +551,7 @@ restore:
BEGIN_FW_FTR_SECTION
ld r5,SOFTE(r1)
FW_FTR_SECTION_ELSE
- b iseries_check_pending_irqs
+ b .Liseries_check_pending_irqs
ALT_FW_FTR_SECTION_END_IFCLR(FW_FEATURE_ISERIES)
2:
TRACE_AND_RESTORE_IRQ(r5);
@@ -623,7 +623,7 @@ ALT_FW_FTR_SECTION_END_IFCLR(FW_FEATURE_
#endif /* CONFIG_PPC_BOOK3E */
-iseries_check_pending_irqs:
+.Liseries_check_pending_irqs:
#ifdef CONFIG_PPC_ISERIES
ld r5,SOFTE(r1)
cmpdi 0,r5,0
next prev parent reply other threads:[~2009-10-18 11:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 11:23 [PATCH 1/3] powerpc: perf_event: Cleanup copy_page output by hiding setup symbol Anton Blanchard
2009-10-18 11:24 ` [PATCH 2/3] powerpc: perf_event: Cleanup output by adding symbols Anton Blanchard
2009-10-18 11:24 ` Anton Blanchard [this message]
2009-10-19 7:23 ` [PATCH 3/3] powerpc: perf_event: Hide iseries_check_pending_irqs Ingo Molnar
2009-10-20 3:50 ` Anton Blanchard
2009-10-20 4:12 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091018112429.GP4808@kryten \
--to=anton@samba.org \
--cc=a.p.zijlstra@chello.nl \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).