From: Wolfram Sang <w.sang@pengutronix.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Wolfgang Denk <wd@denx.de>
Subject: Re: mpc512x/clock: fix clk_get logic
Date: Sat, 31 Oct 2009 14:01:31 +0100 [thread overview]
Message-ID: <20091031130131.GA23009@pengutronix.de> (raw)
In-Reply-To: <1256939657.6372.81.camel@pasglop>
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
Hello Ben,
> Have you considered switching to my proposed device-tree based clock
> reprentation ?
You mean this one?
http://patchwork.ozlabs.org/patch/31551/
Sorry, I have missed it up to now :(
While I think (after one glimpse) this moves things into the right direction,
my priority at the moment is to get the mscan driver working on 512x (and then
to mainline). For that, I needed the patch I posted. I hope I can have another
look at your proposal later on, it looks really worth it.
Until then I'd propose to consider this patch as it fixes a bug in clock
assignment. But I leave the final decision to you maintainers, of course.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-10-31 13:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 9:17 mpc512x/clock: fix clk_get logic Wolfram Sang
2009-10-30 10:54 ` Mark Brown
2009-10-30 11:36 ` Wolfram Sang
2009-10-30 12:02 ` Mark Brown
2009-10-30 17:53 ` [PATCH V2] " Wolfram Sang
2009-11-02 15:17 ` [PATCH] mpc512x/clocks: initialize CAN clocks Wolfram Sang
2009-11-02 18:02 ` Grant Likely
2009-11-02 18:40 ` Wolfram Sang
2009-11-02 21:13 ` Grant Likely
2009-11-02 17:48 ` [PATCH V2] mpc512x/clock: fix clk_get logic Grant Likely
2009-11-02 23:10 ` Stephen Rothwell
2009-11-02 23:49 ` Grant Likely
2009-10-30 21:54 ` Benjamin Herrenschmidt
2009-10-31 13:01 ` Wolfram Sang [this message]
2009-10-31 20:48 ` Benjamin Herrenschmidt
2009-11-02 14:22 ` Wolfram Sang
2009-11-02 16:37 ` Grant Likely
2009-11-02 17:18 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091031130131.GA23009@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).