From: David Miller <davem@davemloft.net>
To: avorontsov@ru.mvista.com
Cc: jdl@jdl.com, netdev@vger.kernel.org, linuxppc-dev@ozlabs.org,
afleming@freescale.com, jason.wessel@windriver.com,
shemminger@vyatta.com, buytenh@wantstofly.org
Subject: Re: [PATCH RFC] gianfar: Do not call skb recycling with disabled IRQs
Date: Sun, 08 Nov 2009 01:08:48 -0800 (PST) [thread overview]
Message-ID: <20091108.010848.116517157.davem@davemloft.net> (raw)
In-Reply-To: <20091105165738.GA31923@oksana.dev.rtsoft.ru>
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Date: Thu, 5 Nov 2009 19:57:38 +0300
> But that basically means that with skb recycling we can't safely
> use KGDBoE, though we can add something like this:
Please stop adding special logic only to your driver to handle these
things.
Either it's a non-issue, or it's going to potentially be an issue for
everyone using skb_recycle_check() in a NAPI driver, right?
So why not add the "in_interrupt()" or whatever check to
skb_recycle_check() and if the context is unsuitable return false (0)
ok?
next prev parent reply other threads:[~2009-11-08 9:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 22:57 [PATCH RFC] gianfar: Make polling safe with IRQs disabled Anton Vorontsov
2009-11-05 14:01 ` Jon Loeliger
2009-11-05 14:20 ` Anton Vorontsov
2009-11-05 14:41 ` Jon Loeliger
2009-11-05 15:43 ` Jon Loeliger
2009-11-05 16:57 ` [PATCH RFC] gianfar: Do not call skb recycling with disabled IRQs Anton Vorontsov
2009-11-05 17:23 ` Kumar Gopalpet-B05799
2009-11-05 17:34 ` Anton Vorontsov
2009-11-05 17:40 ` Jon Loeliger
2009-11-05 17:53 ` Anton Vorontsov
2009-11-06 20:38 ` Jon Loeliger
2009-11-05 17:53 ` Kumar Gopalpet-B05799
2009-11-08 9:08 ` David Miller [this message]
2009-11-09 13:41 ` Anton Vorontsov
2009-11-08 9:05 ` [PATCH RFC] gianfar: Make polling safe with IRQs disabled David Miller
2009-11-09 13:32 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091108.010848.116517157.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=buytenh@wantstofly.org \
--cc=jason.wessel@windriver.com \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).