From: Wolfram Sang <w.sang@pengutronix.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: socketcan-core@lists.berlios.de, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan
Date: Mon, 16 Nov 2009 19:44:16 +0100 [thread overview]
Message-ID: <20091116184416.GA21491@pengutronix.de> (raw)
In-Reply-To: <fa686aa40911130939x54ac53f9x173a875a5a4435d3@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
Hi Grant,
Wolfgang commented on some points already, I will pick up the other remarks,
just one question:
> > + clk_src = of_get_property(np, "fsl,mscan-clk-src", NULL);
> > + if (clk_src && strcmp(clk_src, "ip") == 0)
>
> Should protect against non-null. strncmp() maybe?
"ip" is null-terminated, or what do you mean?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-11-16 18:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 16:14 [PATCH] net/can: add driver for mscan family & mpc52xx_mscan Wolfram Sang
2009-11-13 17:39 ` Grant Likely
2009-11-16 8:40 ` Wolfgang Grandegger
2009-11-16 18:44 ` Wolfram Sang [this message]
2009-11-17 18:26 ` Wolfgang Grandegger
2009-11-17 19:17 ` Wolfgang Grandegger
2009-11-14 4:51 ` David Miller
2009-11-15 11:55 ` Wolfgang Grandegger
2009-11-16 10:12 ` Wolfram Sang
2009-11-16 10:21 ` David Miller
2009-11-16 8:44 ` Wolfgang Grandegger
2009-11-16 10:24 ` Wolfram Sang
2009-11-16 13:08 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116184416.GA21491@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).