* [patch 1/3] powerpc: Sky CPU: redundant or incorrect tests on unsigned
@ 2009-11-17 22:40 akpm
0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2009-11-17 22:40 UTC (permalink / raw)
To: benh; +Cc: waite, roel.kluin, gorcunov, linuxppc-dev, galak, akpm
From: Roel Kluin <roel.kluin@gmail.com>
count is unsigned and cannot be less than 0.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Kumar Gala <galak@gate.crashing.org>
Cc: Brian Waite <waite@skycomputers.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/misc/hdpuftrs/hdpu_cpustate.c | 5 -----
1 file changed, 5 deletions(-)
diff -puN drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned drivers/misc/hdpuftrs/hdpu_cpustate.c
--- a/drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned
+++ a/drivers/misc/hdpuftrs/hdpu_cpustate.c
@@ -121,8 +121,6 @@ static ssize_t cpustate_read(struct file
{
unsigned char data;
- if (count < 0)
- return -EFAULT;
if (count == 0)
return 0;
@@ -137,9 +135,6 @@ static ssize_t cpustate_write(struct fil
{
unsigned char data;
- if (count < 0)
- return -EFAULT;
-
if (count == 0)
return 0;
_
^ permalink raw reply [flat|nested] 2+ messages in thread* [patch 1/3] powerpc: Sky CPU: redundant or incorrect tests on unsigned
@ 2009-08-06 23:00 akpm
0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2009-08-06 23:00 UTC (permalink / raw)
To: benh; +Cc: waite, roel.kluin, gorcunov, linuxppc-dev, galak, akpm
From: Roel Kluin <roel.kluin@gmail.com>
count is unsigned and cannot be less than 0.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Kumar Gala <galak@gate.crashing.org>
Cc: Brian Waite <waite@skycomputers.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/misc/hdpuftrs/hdpu_cpustate.c | 5 -----
1 file changed, 5 deletions(-)
diff -puN drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned drivers/misc/hdpuftrs/hdpu_cpustate.c
--- a/drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned
+++ a/drivers/misc/hdpuftrs/hdpu_cpustate.c
@@ -121,8 +121,6 @@ static ssize_t cpustate_read(struct file
{
unsigned char data;
- if (count < 0)
- return -EFAULT;
if (count == 0)
return 0;
@@ -137,9 +135,6 @@ static ssize_t cpustate_write(struct fil
{
unsigned char data;
- if (count < 0)
- return -EFAULT;
-
if (count == 0)
return 0;
_
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-17 23:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-17 22:40 [patch 1/3] powerpc: Sky CPU: redundant or incorrect tests on unsigned akpm
-- strict thread matches above, loose matches on Subject: below --
2009-08-06 23:00 akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).