* [PATCH] ibm_newemac: Fix EMACx_TRTR[TRT] bit shifts
@ 2009-11-18 0:56 Dave Mitchell
2009-11-18 10:07 ` Stefan Roese
0 siblings, 1 reply; 3+ messages in thread
From: Dave Mitchell @ 2009-11-18 0:56 UTC (permalink / raw)
To: netdev; +Cc: linuxppc-dev, dmitchell
The TRT bit shifts were reversed for EMAC4 and non-EMAC4 during the
port from ibm_emac to ibm_newemac. This patch corrects that error.
Signed-off-by: Dave Mitchell <dmitchell@appliedmicro.com>
Acked-by: Feng Kan <fkan@appliedmicro.com>
Acked-by: Prodyut Hazarika <phazarika@appliedmicro.com>
---
For those curious, these bits control the TX threshold.
drivers/net/ibm_newemac/emac.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ibm_newemac/emac.h b/drivers/net/ibm_newemac/emac.h
index d34adf9..f2751cb 100644
--- a/drivers/net/ibm_newemac/emac.h
+++ b/drivers/net/ibm_newemac/emac.h
@@ -263,8 +263,8 @@ struct emac_regs {
/* EMACx_TRTR */
-#define EMAC_TRTR_SHIFT_EMAC4 27
-#define EMAC_TRTR_SHIFT 24
+#define EMAC_TRTR_SHIFT_EMAC4 24
+#define EMAC_TRTR_SHIFT 27
/* EMAC specific TX descriptor control fields (write access) */
#define EMAC_TX_CTRL_GFCS 0x0200
--
1.6.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ibm_newemac: Fix EMACx_TRTR[TRT] bit shifts
2009-11-18 0:56 [PATCH] ibm_newemac: Fix EMACx_TRTR[TRT] bit shifts Dave Mitchell
@ 2009-11-18 10:07 ` Stefan Roese
2009-11-18 13:11 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Roese @ 2009-11-18 10:07 UTC (permalink / raw)
To: linuxppc-dev; +Cc: netdev, Dave Mitchell, linuxppc-dev
On Wednesday 18 November 2009 01:56:55 Dave Mitchell wrote:
> The TRT bit shifts were reversed for EMAC4 and non-EMAC4 during the
> port from ibm_emac to ibm_newemac. This patch corrects that error.
>
> Signed-off-by: Dave Mitchell <dmitchell@appliedmicro.com>
> Acked-by: Feng Kan <fkan@appliedmicro.com>
> Acked-by: Prodyut Hazarika <phazarika@appliedmicro.com>
Acked-by: Stefan Roese <sr@denx.de>
Would be great if this could go into 2.6.32. Thanks.
Cheers,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ibm_newemac: Fix EMACx_TRTR[TRT] bit shifts
2009-11-18 10:07 ` Stefan Roese
@ 2009-11-18 13:11 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-11-18 13:11 UTC (permalink / raw)
To: sr; +Cc: netdev, linuxppc-dev, dmitchell, linuxppc-dev
From: Stefan Roese <sr@denx.de>
Date: Wed, 18 Nov 2009 11:07:51 +0100
> On Wednesday 18 November 2009 01:56:55 Dave Mitchell wrote:
>> The TRT bit shifts were reversed for EMAC4 and non-EMAC4 during the
>> port from ibm_emac to ibm_newemac. This patch corrects that error.
>>
>> Signed-off-by: Dave Mitchell <dmitchell@appliedmicro.com>
>> Acked-by: Feng Kan <fkan@appliedmicro.com>
>> Acked-by: Prodyut Hazarika <phazarika@appliedmicro.com>
>
> Acked-by: Stefan Roese <sr@denx.de>
>
> Would be great if this could go into 2.6.32. Thanks.
Applied to net-2.6, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-18 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-18 0:56 [PATCH] ibm_newemac: Fix EMACx_TRTR[TRT] bit shifts Dave Mitchell
2009-11-18 10:07 ` Stefan Roese
2009-11-18 13:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).