From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 55C18B7B64 for ; Fri, 4 Dec 2009 02:04:26 +1100 (EST) Date: Thu, 3 Dec 2009 10:04:17 -0500 From: Neil Horman To: linuxppc-dev@ozlabs.org Subject: Re: [PATCH] ppc64: re-enable kexec to allow module loads with CONFIG_MODVERSIONS and CONFIG_RELOCATABLE turned on Message-ID: <20091203150417.GA17521@hmsreliant.think-freely.org> References: <20091119195216.GC11414@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20091119195216.GC11414@hmsreliant.think-freely.org> Cc: rusty@rustcorp.com.au, paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >>> Paul, Ben, given that Rusty hasn't come back with any opinion on this patch, >>do you >>> feel comfortable merging it via the ppc tree? Currently the earlyinit >routine >>> is only compiled in and used for your arch, so I think its fairly benign. >> >>Sorry, I *did* track down the archives for linuxppc-dev, then find your post, >>then read your patch. But I didn't actually reply. >> >>Other than minor issues, there's one significant one: you shouldn't be trying >>to change rodata. It might work on PPC today, but it's poor form at least. >> >>How's this? Untested on ppc. >> >I'll try grab a ppc64 system and test this soon. > >>Other changes: >>1) I also changed reloc_start to an array; this is a good idea for any >> linker-defined symbols so the compiler can't make assumptions about size. >Ok, I'll certainly trust your linker skill over mine :) > >>2) local.h? How about module.h? >Seems good to me >>3) I don't think the extra ". = 0" is necessary. >Its not, I was just trying to be clear about where reloc_start was to be placed. > >>4) ARCH_USES_RELOC_ENTRIES isn't clear enough for me; I prefer >> ARCH_RELOCATE_KCRCTAB. >Sounds good to me. > > >I'll test this as soon as I'm able >Thanks! >Neil > Just finished testing your patch Rusty, it all works quite well, Thanks! Will this be going in via your tree, or the ppc tree? Acked-by: Neil Horman Neil