From: Torsten Duwe <duwe@lst.de>
To: arun@linux.vnet.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org
Subject: Re: [v10 PATCH 2/9]: cpuidle: cleanup drivers/cpuidle/cpuidle.c
Date: Mon, 7 Dec 2009 11:17:57 +0100 [thread overview]
Message-ID: <200912071117.58163.duwe@lst.de> (raw)
In-Reply-To: <20091206051928.GA18300@linux.vnet.ibm.com>
On Sunday 06 December 2009, Arun R Bharadwaj wrote:
> Peter objected to the idea of integrating this with the old pm_idle
> because it has already caused a lot of problems on x86 and we wouldn't
> want to be doing the same mistake on POWER. The discussion related to
> that could be found here http://lkml.org/lkml/2009/8/26/233
And BenH has sketched how it should be done on ppc, in that thread:
http://lkml.org/lkml/2009/8/26/624 AFAIS this comment is still valid for v10.
Not only I would like to understand what is the conceptual idea behind the
other changes. Nothing wrong with cleanups, but there's got to be a purpose
and benefits.
Torsten
next prev parent reply other threads:[~2009-12-07 10:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 9:54 [v10 PATCH 0/9] cpuidle: cleanup cpuidle/ introduce cpuidle to POWER Arun R Bharadwaj
2009-12-02 9:55 ` [v10 PATCH 1/9]: cpuidle: Design documentation patch Arun R Bharadwaj
2009-12-02 9:57 ` [v10 PATCH 2/9]: cpuidle: cleanup drivers/cpuidle/cpuidle.c Arun R Bharadwaj
2009-12-04 22:20 ` Torsten Duwe
2009-12-06 5:19 ` Arun R Bharadwaj
2009-12-07 10:17 ` Torsten Duwe [this message]
2009-12-07 10:56 ` Arun R Bharadwaj
2009-12-02 9:58 ` [v10 PATCH 3/9]: cpuidle: implement a list based approach to register a set of idle routines Arun R Bharadwaj
2009-12-02 9:59 ` [v10 PATCH 4/9]: x86: refactor x86 idle power management code, remove all instances of pm_idle Arun R Bharadwaj
2009-12-02 10:00 ` [v10 PATCH 5/9]: POWER: enable cpuidle for POWER Arun R Bharadwaj
2009-12-02 10:01 ` [v10 PATCH 6/9]: pSeries/cpuidle: refactor pseries idle loops Arun R Bharadwaj
2009-12-04 2:45 ` Benjamin Herrenschmidt
2009-12-02 10:01 ` [v10 PATCH 7/9]: POWER: add a default_idle idle loop for POWER Arun R Bharadwaj
2009-12-02 10:02 ` [v10 PATCH 8/9]: pSeries: implement pSeries processor idle module Arun R Bharadwaj
2009-12-04 2:47 ` Benjamin Herrenschmidt
2009-12-04 8:15 ` Arun R Bharadwaj
2009-12-04 10:00 ` Benjamin Herrenschmidt
2009-12-15 11:49 ` Arun R Bharadwaj
2009-12-02 10:03 ` [v10 PATCH 9/9]: POWER: Enable default_idle when power_save=off Arun R Bharadwaj
2009-12-02 17:41 ` Daniel Walker
2009-12-03 6:33 ` Arun R Bharadwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912071117.58163.duwe@lst.de \
--to=duwe@lst.de \
--cc=a.p.zijlstra@chello.nl \
--cc=arun@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).