patch status

patch status

[Tirumala Reddy Marri]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

Hi Ben,

 Did you get the chance to review the patch I sent it on Dec-1 2009

 

http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-December/078436.html

 

Regards,

MArri


[-- Attachment #2: Type: text/html, Size: 2030 bytes --]

Re: patch status

[Josh Boyer]

On Mon, Dec 07, 2009 at 02:01:58PM -0800, Tirumala Reddy Marri wrote:
>Hi Ben,
>
> Did you get the chance to review the patch I sent it on Dec-1 2009
>
> 
>
>http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-December/078436.html

Ben has to review lots of patches.  Please be patient.  Also, your patch is
tracked via patchwork here:

http://patchwork.ozlabs.org/patch/39865/

so you can see the state as it progresses.

Further, it would have been helpful to CC the maintainer of the 4xx sub-arch
(me) since it impacts that platform and you could have gotten some review more
quickly.  I didn't notice it until this afternoon.

Lastly, your patch has lots of magical values in it.  While I have no doubt
they are correct, I can't find any documentation for 460SX on the AMCC website
aside from some small product briefs.  Perhaps I've overlooked the CPU manual,
but since I don't have such a board or the manual for it, it would be nice to
know what kind of testing has been done with this patch.  A simple statement
such as "tested on kernel <version> with a <network, raid, whatever> pci-e
card successfully" would go a long way.

This is not a rant or complaint about the code.  Just a reminder that the
community doesn't always move at the pace we would all like :).  I'll try and
look over the patch more carefully tomorrow.

josh

RE: patch status

[Tirumala Reddy Marri]

Josh,
  Sorry for my ignorance that I did not copy you first. From now on I
will make sure you are cc'ed .  I will send you the copy of user manual
which is available on external website.=20

  Should I send new patch with what is tested with this change or is it
enough to write in email ?

Regards,
Marri

-----Original Message-----
From: Josh Boyer [mailto:jwboyer@linux.vnet.ibm.com]=20
Sent: Monday, December 07, 2009 4:53 PM
To: Tirumala Reddy Marri
Cc: benh@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org
Subject: Re: patch status

On Mon, Dec 07, 2009 at 02:01:58PM -0800, Tirumala Reddy Marri wrote:
>Hi Ben,
>
> Did you get the chance to review the patch I sent it on Dec-1 2009
>
>=20
>
>http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-December/078436.htm
l

Ben has to review lots of patches.  Please be patient.  Also, your patch
is
tracked via patchwork here:

http://patchwork.ozlabs.org/patch/39865/

so you can see the state as it progresses.

Further, it would have been helpful to CC the maintainer of the 4xx
sub-arch
(me) since it impacts that platform and you could have gotten some
review more
quickly.  I didn't notice it until this afternoon.

Lastly, your patch has lots of magical values in it.  While I have no
doubt
they are correct, I can't find any documentation for 460SX on the AMCC
website
aside from some small product briefs.  Perhaps I've overlooked the CPU
manual,
but since I don't have such a board or the manual for it, it would be
nice to
know what kind of testing has been done with this patch.  A simple
statement
such as "tested on kernel <version> with a <network, raid, whatever>
pci-e
card successfully" would go a long way.

This is not a rant or complaint about the code.  Just a reminder that
the
community doesn't always move at the pace we would all like :).  I'll
try and
look over the patch more carefully tomorrow.

josh

Re: patch status

[Josh Boyer]

On Mon, Dec 07, 2009 at 05:41:35PM -0800, Tirumala Reddy Marri wrote:
>Josh,
>  Sorry for my ignorance that I did not copy you first. From now on I

No reason to apologize.  Working with the Linux community is a learning
process.

>will make sure you are cc'ed .  I will send you the copy of user manual
>which is available on external website. 

A URL to it would be fine.  I still haven't managed to find it, but perhaps
the 'ALL available documents/types listed' link on this page:

http://www.appliedmicro.com/MyAMCC/jsp/public/productDetail/product_detail.jsp?productID=PPC460SX

doesn't really mean all?

>
>  Should I send new patch with what is tested with this change or is it
>enough to write in email ?

Just reply to the patch is fine.  No need to send a new one if there are no
code changes.

josh

RE: patch status

[Tirumala Reddy Marri]

>>A URL to it would be fine.  I still haven't managed to find it, but
perhaps
>>the 'ALL available documents/types listed' link on this page:

>>http://www.appliedmicro.com/MyAMCC/jsp/public/productDetail/product_de
tail.jsp?productID=3DPPC460SX

>>doesn't really mean all?

Looks like need a login to get the actual engineering manual. It is also
whipped with CD of evaluation board.


>>Just reply to the patch is fine.  No need to send a new one if there
are no
>>code changes.


There are no new changes. I will reply to the patch.

Thanks,
Marri