From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-mail-306.bluehost.com (outbound-mail-306.bluehost.com [67.222.53.252]) by ozlabs.org (Postfix) with SMTP id 0EB8EB6EF6 for ; Thu, 17 Dec 2009 06:30:00 +1100 (EST) Date: Wed, 16 Dec 2009 11:23:02 -0800 From: Jesse Barnes To: Benjamin Herrenschmidt Subject: Re: [PATCH] cardbus: Add a fixup hook and fix powerpc Message-ID: <20091216112302.5b9b8e5c@jbarnes-piketon> In-Reply-To: <1260341533.16132.20.camel@pasglop> References: <1260341533.16132.20.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Olof Johansson , linux-pci@vger.kernel.org, blofeldus@yahoo.com, linuxppc-dev , "linux-kernel@vger.kernel.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 09 Dec 2009 17:52:13 +1100 Benjamin Herrenschmidt wrote: > The cardbus code creates PCI devices without ever going through the > necessary fixup bits and pieces that normal PCI devices go through. > > There's in fact a commented out call to pcibios_fixup_bus() in there, > it's commented because ... it doesn't work. > > I could make pcibios_fixup_bus() do the right thing on powerpc easily > but I felt it cleaner instead to provide a specific hook > pci_fixup_cardbus for which a weak empty implementation is provided > by the PCI core. > > This fixes cardbus on powerbooks and probably all other PowerPC > platforms which was broken completely for ever on some platforms and > since 2.6.31 on others such as PowerBooks when we made the DMA ops > mandatory (since those are setup by the fixups). > > Signed-off-by: Benjamin Herrenschmidt Applied, thanks. Had to fix up a conflict since someone had "helpfully" changed the comment from a // to a /* .. */ in cardbus.c. -- Jesse Barnes, Intel Open Source Technology Center