* [PATCH] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV
@ 2009-12-18 5:52 Benjamin Herrenschmidt
2009-12-18 16:55 ` Randy Dunlap
2009-12-18 19:19 ` [PATCH v3] " Geoff Levand
0 siblings, 2 replies; 8+ messages in thread
From: Benjamin Herrenschmidt @ 2009-12-18 5:52 UTC (permalink / raw)
To: linux-wireless; +Cc: Geert Uytterhoeven, linuxppc-dev
The option to support the old style PSK interface in the PS3
GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Please send to Linus asap (or I can put it in powerpc.git) as it's
breaking one of my test build configs :-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index e58a653..c0ecc77 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2358,6 +2358,7 @@ config GELIC_WIRELESS
config GELIC_WIRELESS_OLD_PSK_INTERFACE
bool "PS3 Wireless private PSK interface (OBSOLETE)"
depends on GELIC_WIRELESS
+ select WEXT_PRIV
help
This option retains the obsolete private interface to pass
the PSK from user space programs to the driver. The PSK
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV
2009-12-18 5:52 [PATCH] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV Benjamin Herrenschmidt
@ 2009-12-18 16:55 ` Randy Dunlap
2009-12-18 18:24 ` [PATCH v2] " Geoff Levand
2009-12-18 22:09 ` [PATCH] " Benjamin Herrenschmidt
2009-12-18 19:19 ` [PATCH v3] " Geoff Levand
1 sibling, 2 replies; 8+ messages in thread
From: Randy Dunlap @ 2009-12-18 16:55 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Geert Uytterhoeven, linuxppc-dev, linux-wireless
On Fri, 18 Dec 2009 16:52:54 +1100 Benjamin Herrenschmidt wrote:
> The option to support the old style PSK interface in the PS3
> GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Please send to Linus asap (or I can put it in powerpc.git) as it's
> breaking one of my test build configs :-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index e58a653..c0ecc77 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2358,6 +2358,7 @@ config GELIC_WIRELESS
> config GELIC_WIRELESS_OLD_PSK_INTERFACE
> bool "PS3 Wireless private PSK interface (OBSOLETE)"
> depends on GELIC_WIRELESS
> + select WEXT_PRIV
> help
> This option retains the obsolete private interface to pass
> the PSK from user space programs to the driver. The PSK
Probably also needs
depends on WLAN
to prevent build failures.
---
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV
2009-12-18 16:55 ` Randy Dunlap
@ 2009-12-18 18:24 ` Geoff Levand
2009-12-18 18:30 ` Johannes Berg
2009-12-18 22:09 ` Benjamin Herrenschmidt
2009-12-18 22:09 ` [PATCH] " Benjamin Herrenschmidt
1 sibling, 2 replies; 8+ messages in thread
From: Geoff Levand @ 2009-12-18 18:24 UTC (permalink / raw)
To: Randy Dunlap
Cc: Geert Uytterhoeven, linux-wireless@vger.kernel.org, linuxppc-dev,
Hamish Guthrie
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
The option to support the old style PSK interface in the PS3
GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
v2: Added 'depends on WLAN'.
Please send to Linus asap (or I can put it in powerpc.git) as it's
breaking one of my test build configs :-)
Just as a note, I asked Hamish to work to remove this option.
No distros use it anymore, so we don't need it.
-Geoff
---
drivers/net/Kconfig | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2357,7 +2357,9 @@ config GELIC_WIRELESS
config GELIC_WIRELESS_OLD_PSK_INTERFACE
bool "PS3 Wireless private PSK interface (OBSOLETE)"
+ depends on WLAN
depends on GELIC_WIRELESS
+ select WEXT_PRIV
help
This option retains the obsolete private interface to pass
the PSK from user space programs to the driver. The PSK
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV
2009-12-18 18:24 ` [PATCH v2] " Geoff Levand
@ 2009-12-18 18:30 ` Johannes Berg
2009-12-18 19:01 ` Geoff Levand
2009-12-18 22:09 ` Benjamin Herrenschmidt
1 sibling, 1 reply; 8+ messages in thread
From: Johannes Berg @ 2009-12-18 18:30 UTC (permalink / raw)
To: Geoff Levand
Cc: Randy Dunlap, linux-wireless@vger.kernel.org, Geert Uytterhoeven,
linuxppc-dev, Hamish Guthrie
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
On Fri, 2009-12-18 at 10:24 -0800, Geoff Levand wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> The option to support the old style PSK interface in the PS3
> GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
> ---
> v2: Added 'depends on WLAN'.
Won't you want 'depends on WLAN' for GELIC_WIRELESS instead of here?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV
2009-12-18 18:30 ` Johannes Berg
@ 2009-12-18 19:01 ` Geoff Levand
0 siblings, 0 replies; 8+ messages in thread
From: Geoff Levand @ 2009-12-18 19:01 UTC (permalink / raw)
To: Johannes Berg
Cc: Randy Dunlap, linux-wireless@vger.kernel.org, Geert Uytterhoeven,
linuxppc-dev, Hamish Guthrie
On 12/18/2009 10:30 AM, Johannes Berg wrote:
> On Fri, 2009-12-18 at 10:24 -0800, Geoff Levand wrote:
>> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>
>> The option to support the old style PSK interface in the PS3
>> GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set
>>
>> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
>> ---
>> v2: Added 'depends on WLAN'.
>
> Won't you want 'depends on WLAN' for GELIC_WIRELESS instead of here?
Yes, that seems correct. I'll post an update v3.
-Geoff
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV
2009-12-18 18:24 ` [PATCH v2] " Geoff Levand
2009-12-18 18:30 ` Johannes Berg
@ 2009-12-18 22:09 ` Benjamin Herrenschmidt
1 sibling, 0 replies; 8+ messages in thread
From: Benjamin Herrenschmidt @ 2009-12-18 22:09 UTC (permalink / raw)
To: Geoff Levand
Cc: Randy Dunlap, linuxppc-dev, Geert Uytterhoeven,
linux-wireless@vger.kernel.org, Hamish Guthrie
On Fri, 2009-12-18 at 10:24 -0800, Geoff Levand wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> The option to support the old style PSK interface in the PS3
> GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
> ---
> v2: Added 'depends on WLAN'.
>
> Please send to Linus asap (or I can put it in powerpc.git) as it's
> breaking one of my test build configs :-)
>
> Just as a note, I asked Hamish to work to remove this option.
> No distros use it anymore, so we don't need it.
Geoff, the depends on WLAN should be on config GELIC_WIRELESS
Cheers,
Ben.
> -Geoff
> ---
> drivers/net/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2357,7 +2357,9 @@ config GELIC_WIRELESS
>
> config GELIC_WIRELESS_OLD_PSK_INTERFACE
> bool "PS3 Wireless private PSK interface (OBSOLETE)"
> + depends on WLAN
> depends on GELIC_WIRELESS
> + select WEXT_PRIV
> help
> This option retains the obsolete private interface to pass
> the PSK from user space programs to the driver. The PSK
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV
2009-12-18 16:55 ` Randy Dunlap
2009-12-18 18:24 ` [PATCH v2] " Geoff Levand
@ 2009-12-18 22:09 ` Benjamin Herrenschmidt
1 sibling, 0 replies; 8+ messages in thread
From: Benjamin Herrenschmidt @ 2009-12-18 22:09 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Geert Uytterhoeven, linuxppc-dev, linux-wireless
On Fri, 2009-12-18 at 08:55 -0800, Randy Dunlap wrote:
>
> Probably also needs
> depends on WLAN
> to prevent build failures.
Yeah, GELIC_WIRELESS should probably. I'll do a separate patch next week
but feel free to beat me to it.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV
2009-12-18 5:52 [PATCH] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV Benjamin Herrenschmidt
2009-12-18 16:55 ` Randy Dunlap
@ 2009-12-18 19:19 ` Geoff Levand
1 sibling, 0 replies; 8+ messages in thread
From: Geoff Levand @ 2009-12-18 19:19 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Geert Uytterhoeven, linuxppc-dev, linux-wireless@vger.kernel.org
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
The option to support the old style PSK interface in the PS3
GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
v2: Added 'depends on WLAN'.
v3: Moved 'depends on WLAN' to GELIC_WIRELESS.
Please send to Linus asap (or I can put it in powerpc.git) as it's
breaking one of my test build configs :-)
---
drivers/net/Kconfig | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2346,6 +2346,7 @@ config GELIC_NET
config GELIC_WIRELESS
bool "PS3 Wireless support"
+ depends on WLAN
depends on GELIC_NET
select WIRELESS_EXT
help
@@ -2358,6 +2359,7 @@ config GELIC_WIRELESS
config GELIC_WIRELESS_OLD_PSK_INTERFACE
bool "PS3 Wireless private PSK interface (OBSOLETE)"
depends on GELIC_WIRELESS
+ select WEXT_PRIV
help
This option retains the obsolete private interface to pass
the PSK from user space programs to the driver. The PSK
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2009-12-18 22:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-18 5:52 [PATCH] ps3_gelic_wireless: Fix build failure due to missing WEXT_PRIV Benjamin Herrenschmidt
2009-12-18 16:55 ` Randy Dunlap
2009-12-18 18:24 ` [PATCH v2] " Geoff Levand
2009-12-18 18:30 ` Johannes Berg
2009-12-18 19:01 ` Geoff Levand
2009-12-18 22:09 ` Benjamin Herrenschmidt
2009-12-18 22:09 ` [PATCH] " Benjamin Herrenschmidt
2009-12-18 19:19 ` [PATCH v3] " Geoff Levand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).