From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jeremy Kerr <jeremy.kerr@canonical.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] proc_devtree: fix THIS_MODULE without module.h
Date: Sat, 9 Jan 2010 13:01:04 +0200 [thread overview]
Message-ID: <20100109110104.GA20100@x200> (raw)
In-Reply-To: <1262830753.577814.127040702434.1.gpush@pororo>
On Thu, Jan 07, 2010 at 01:19:13PM +1100, Jeremy Kerr wrote:
> Commit e22f628395432b967f2f505858c64450f7835365 introduced a build
> breakage for ARM devtree work: the THIS_MODULE macro was added, but we
> don't have module.h
>
> This change adds the necessary #include to get THIS_MODULE defined.
> While we could just replace it with NULL (PROC_FS is a bool, not a
> tristate), using THIS_MODULE will prevent unexpected breakage if we
> ever do compile this as a module.
I'd say, remove .owner line.
It definitely not needed in non-modular code.
> --- a/fs/proc/proc_devtree.c
> +++ b/fs/proc/proc_devtree.c
> @@ -11,6 +11,7 @@
> #include <linux/stat.h>
> #include <linux/string.h>
> #include <linux/of.h>
> +#include <linux/module.h>
next prev parent reply other threads:[~2010-01-09 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 2:19 [PATCH] proc_devtree: fix THIS_MODULE without module.h Jeremy Kerr
2010-01-09 11:01 ` Alexey Dobriyan [this message]
2010-01-11 22:58 ` Grant Likely
2010-01-12 17:41 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100109110104.GA20100@x200 \
--to=adobriyan@gmail.com \
--cc=jeremy.kerr@canonical.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).