From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-fx0-f222.google.com (mail-fx0-f222.google.com [209.85.220.222]) by ozlabs.org (Postfix) with ESMTP id 881F0B7C32 for ; Sat, 9 Jan 2010 22:01:19 +1100 (EST) Received: by fxm22 with SMTP id 22so22574600fxm.2 for ; Sat, 09 Jan 2010 03:01:15 -0800 (PST) Date: Sat, 9 Jan 2010 13:01:04 +0200 From: Alexey Dobriyan To: Jeremy Kerr Subject: Re: [PATCH] proc_devtree: fix THIS_MODULE without module.h Message-ID: <20100109110104.GA20100@x200> References: <1262830753.577814.127040702434.1.gpush@pororo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1262830753.577814.127040702434.1.gpush@pororo> Cc: linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Jan 07, 2010 at 01:19:13PM +1100, Jeremy Kerr wrote: > Commit e22f628395432b967f2f505858c64450f7835365 introduced a build > breakage for ARM devtree work: the THIS_MODULE macro was added, but we > don't have module.h > > This change adds the necessary #include to get THIS_MODULE defined. > While we could just replace it with NULL (PROC_FS is a bool, not a > tristate), using THIS_MODULE will prevent unexpected breakage if we > ever do compile this as a module. I'd say, remove .owner line. It definitely not needed in non-modular code. > --- a/fs/proc/proc_devtree.c > +++ b/fs/proc/proc_devtree.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include