From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-fx0-f222.google.com (mail-fx0-f222.google.com [209.85.220.222]) by ozlabs.org (Postfix) with ESMTP id 2E2D51007D2 for ; Wed, 13 Jan 2010 04:41:31 +1100 (EST) Received: by fxm22 with SMTP id 22so26991784fxm.2 for ; Tue, 12 Jan 2010 09:41:27 -0800 (PST) Date: Tue, 12 Jan 2010 19:41:25 +0200 From: Alexey Dobriyan To: Grant Likely Subject: Re: [PATCH] proc_devtree: fix THIS_MODULE without module.h Message-ID: <20100112174125.GA4260@x200> References: <1262830753.577814.127040702434.1.gpush@pororo> <20100109110104.GA20100@x200> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: Jeremy Kerr , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jan 11, 2010 at 03:58:47PM -0700, Grant Likely wrote: > On Sat, Jan 9, 2010 at 4:01 AM, Alexey Dobriyan wrote: > > I'd say, remove .owner line. > > It definitely not needed in non-modular code. > > No. Jeremy's fix is the better one. Having the .owner line doesn't > cost anything and it is better to have it populated; even if only as > an example. Core proc code doesn't use it anymore.