* [PATCH] powerpc/85xx: Fix oops during MSI driver probe on MPC85xxMDS boards
@ 2009-12-15 22:58 Anton Vorontsov
2010-01-18 15:53 ` Anton Vorontsov
2010-01-25 16:54 ` Kumar Gala
0 siblings, 2 replies; 4+ messages in thread
From: Anton Vorontsov @ 2009-12-15 22:58 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
MPC85xx chips report the wrong value in feature reporting register,
and that causes the following oops:
Unable to handle kernel paging request for data at address 0x00000c00
Faulting instruction address: 0xc0019294
Oops: Kernel access of bad area, sig: 11 [#1]
MPC8569 MDS
Modules linked in:
[...]
NIP [c0019294] mpic_set_irq_type+0x2f0/0x368
LR [c0019124] mpic_set_irq_type+0x180/0x368
Call Trace:
[ef851d60] [c0019124] mpic_set_irq_type+0x180/0x368 (unreliable)
[ef851d90] [c007958c] __irq_set_trigger+0x44/0xd4
[ef851db0] [c007b550] set_irq_type+0x40/0x7c
[ef851dc0] [c0004a60] irq_create_of_mapping+0xb4/0x114
[ef851df0] [c0004af0] irq_of_parse_and_map+0x30/0x40
[ef851e20] [c0405678] fsl_of_msi_probe+0x1a0/0x328
[ef851e60] [c02e6438] of_platform_device_probe+0x5c/0x84
[...]
This is because mpic_alloc() assigns wrong values to
mpic->isu_{size,shift,mask}, and things eventually break when
_mpic_irq_read() is trying to use them.
This patch fixes the issue by enabling MPIC_BROKEN_FRR_NIRQS quirk.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
arch/powerpc/platforms/85xx/mpc85xx_mds.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
index c5028a2..6491f7c 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
@@ -338,7 +338,8 @@ static void __init mpc85xx_mds_pic_init(void)
}
mpic = mpic_alloc(np, r.start,
- MPIC_PRIMARY | MPIC_WANTS_RESET | MPIC_BIG_ENDIAN,
+ MPIC_PRIMARY | MPIC_WANTS_RESET | MPIC_BIG_ENDIAN |
+ MPIC_BROKEN_FRR_NIRQS,
0, 256, " OpenPIC ");
BUG_ON(mpic == NULL);
of_node_put(np);
--
1.6.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc/85xx: Fix oops during MSI driver probe on MPC85xxMDS boards
2009-12-15 22:58 [PATCH] powerpc/85xx: Fix oops during MSI driver probe on MPC85xxMDS boards Anton Vorontsov
@ 2010-01-18 15:53 ` Anton Vorontsov
2010-01-19 19:15 ` Kumar Gala
2010-01-25 16:54 ` Kumar Gala
1 sibling, 1 reply; 4+ messages in thread
From: Anton Vorontsov @ 2010-01-18 15:53 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
On Wed, Dec 16, 2009 at 01:58:09AM +0300, Anton Vorontsov wrote:
> MPC85xx chips report the wrong value in feature reporting register,
> and that causes the following oops:
>
> Unable to handle kernel paging request for data at address 0x00000c00
> Faulting instruction address: 0xc0019294
> Oops: Kernel access of bad area, sig: 11 [#1]
> MPC8569 MDS
> Modules linked in:
> [...]
> NIP [c0019294] mpic_set_irq_type+0x2f0/0x368
> LR [c0019124] mpic_set_irq_type+0x180/0x368
> Call Trace:
> [ef851d60] [c0019124] mpic_set_irq_type+0x180/0x368 (unreliable)
> [ef851d90] [c007958c] __irq_set_trigger+0x44/0xd4
> [ef851db0] [c007b550] set_irq_type+0x40/0x7c
> [ef851dc0] [c0004a60] irq_create_of_mapping+0xb4/0x114
> [ef851df0] [c0004af0] irq_of_parse_and_map+0x30/0x40
> [ef851e20] [c0405678] fsl_of_msi_probe+0x1a0/0x328
> [ef851e60] [c02e6438] of_platform_device_probe+0x5c/0x84
> [...]
>
> This is because mpic_alloc() assigns wrong values to
> mpic->isu_{size,shift,mask}, and things eventually break when
> _mpic_irq_read() is trying to use them.
>
> This patch fixes the issue by enabling MPIC_BROKEN_FRR_NIRQS quirk.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
Kumar,
Did you miss this patch or it's just in a queue for review?
Thanks!
> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
> index c5028a2..6491f7c 100644
> --- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c
> +++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
> @@ -338,7 +338,8 @@ static void __init mpc85xx_mds_pic_init(void)
> }
>
> mpic = mpic_alloc(np, r.start,
> - MPIC_PRIMARY | MPIC_WANTS_RESET | MPIC_BIG_ENDIAN,
> + MPIC_PRIMARY | MPIC_WANTS_RESET | MPIC_BIG_ENDIAN |
> + MPIC_BROKEN_FRR_NIRQS,
> 0, 256, " OpenPIC ");
> BUG_ON(mpic == NULL);
> of_node_put(np);
> --
> 1.6.3.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc/85xx: Fix oops during MSI driver probe on MPC85xxMDS boards
2010-01-18 15:53 ` Anton Vorontsov
@ 2010-01-19 19:15 ` Kumar Gala
0 siblings, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2010-01-19 19:15 UTC (permalink / raw)
To: avorontsov; +Cc: linuxppc-dev
On Jan 18, 2010, at 9:53 AM, Anton Vorontsov wrote:
> On Wed, Dec 16, 2009 at 01:58:09AM +0300, Anton Vorontsov wrote:
>> MPC85xx chips report the wrong value in feature reporting register,
>> and that causes the following oops:
>>
>> Unable to handle kernel paging request for data at address 0x00000c00
>> Faulting instruction address: 0xc0019294
>> Oops: Kernel access of bad area, sig: 11 [#1]
>> MPC8569 MDS
>> Modules linked in:
>> [...]
>> NIP [c0019294] mpic_set_irq_type+0x2f0/0x368
>> LR [c0019124] mpic_set_irq_type+0x180/0x368
>> Call Trace:
>> [ef851d60] [c0019124] mpic_set_irq_type+0x180/0x368 (unreliable)
>> [ef851d90] [c007958c] __irq_set_trigger+0x44/0xd4
>> [ef851db0] [c007b550] set_irq_type+0x40/0x7c
>> [ef851dc0] [c0004a60] irq_create_of_mapping+0xb4/0x114
>> [ef851df0] [c0004af0] irq_of_parse_and_map+0x30/0x40
>> [ef851e20] [c0405678] fsl_of_msi_probe+0x1a0/0x328
>> [ef851e60] [c02e6438] of_platform_device_probe+0x5c/0x84
>> [...]
>>
>> This is because mpic_alloc() assigns wrong values to
>> mpic->isu_{size,shift,mask}, and things eventually break when
>> _mpic_irq_read() is trying to use them.
>>
>> This patch fixes the issue by enabling MPIC_BROKEN_FRR_NIRQS quirk.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>> ---
>
> Kumar,
>
> Did you miss this patch or it's just in a queue for review?
>
> Thanks!
I just missed it will pick it up in a merge request to benh/linus.
- k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/85xx: Fix oops during MSI driver probe on MPC85xxMDS boards
2009-12-15 22:58 [PATCH] powerpc/85xx: Fix oops during MSI driver probe on MPC85xxMDS boards Anton Vorontsov
2010-01-18 15:53 ` Anton Vorontsov
@ 2010-01-25 16:54 ` Kumar Gala
1 sibling, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2010-01-25 16:54 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
On Dec 15, 2009, at 4:58 PM, Anton Vorontsov wrote:
> MPC85xx chips report the wrong value in feature reporting register,
> and that causes the following oops:
>
> Unable to handle kernel paging request for data at address 0x00000c00
> Faulting instruction address: 0xc0019294
> Oops: Kernel access of bad area, sig: 11 [#1]
> MPC8569 MDS
> Modules linked in:
> [...]
> NIP [c0019294] mpic_set_irq_type+0x2f0/0x368
> LR [c0019124] mpic_set_irq_type+0x180/0x368
> Call Trace:
> [ef851d60] [c0019124] mpic_set_irq_type+0x180/0x368 (unreliable)
> [ef851d90] [c007958c] __irq_set_trigger+0x44/0xd4
> [ef851db0] [c007b550] set_irq_type+0x40/0x7c
> [ef851dc0] [c0004a60] irq_create_of_mapping+0xb4/0x114
> [ef851df0] [c0004af0] irq_of_parse_and_map+0x30/0x40
> [ef851e20] [c0405678] fsl_of_msi_probe+0x1a0/0x328
> [ef851e60] [c02e6438] of_platform_device_probe+0x5c/0x84
> [...]
>
> This is because mpic_alloc() assigns wrong values to
> mpic->isu_{size,shift,mask}, and things eventually break when
> _mpic_irq_read() is trying to use them.
>
> This patch fixes the issue by enabling MPIC_BROKEN_FRR_NIRQS quirk.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
applied to merge for 2.6.33
- k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-25 16:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15 22:58 [PATCH] powerpc/85xx: Fix oops during MSI driver probe on MPC85xxMDS boards Anton Vorontsov
2010-01-18 15:53 ` Anton Vorontsov
2010-01-19 19:15 ` Kumar Gala
2010-01-25 16:54 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).