From: David Miller <davem@davemloft.net>
To: avorontsov@ru.mvista.com
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
B06378@freescale.com, lsorense@csclub.uwaterloo.ca
Subject: Re: [PATCH] ucc_geth: Fix full TX queue processing
Date: Tue, 19 Jan 2010 02:00:38 -0800 (PST) [thread overview]
Message-ID: <20100119.020038.152864417.davem@davemloft.net> (raw)
In-Reply-To: <20100118154750.GA9224@oksana.dev.rtsoft.ru>
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Date: Mon, 18 Jan 2010 18:47:50 +0300
> From: Jiajun Wu <b06378@freescale.com>
>
> commit 7583605b6d29f1f7f6fc505b883328089f3485ad ("ucc_geth: Fix empty
> TX queue processing") fixed empty TX queue mishandling, but didn't
> account another corner case: when TX queue becomes full.
>
> Without this patch the driver will stop transmiting when TX queue
> becomes full since 'bd == ugeth->txBd[txQ]' actually checks for
> two things: queue empty or full.
>
> Let's better check for NULL skb, which unambiguously signals an empty
> queue.
>
> Signed-off-by: Jiajun Wu <b06378@freescale.com>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Applied.
prev parent reply other threads:[~2010-01-19 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 15:47 [PATCH] ucc_geth: Fix full TX queue processing Anton Vorontsov
2010-01-19 10:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119.020038.152864417.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=B06378@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).