From: Wim Van Sebroeck <wim@iguana.be>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org, uclinux-dist-devel@blackfin.uclinux.org,
Joe Perches <joe@perches.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-omap@vger.kernel.org,
Florian Fainelli <florian@openwrt.org>
Subject: Re: [RFC] [PATCH] watchdog_info separation and constify
Date: Tue, 19 Jan 2010 23:00:14 +0100 [thread overview]
Message-ID: <20100119220014.GG3804@infomag.iguana.be> (raw)
In-Reply-To: <20100119212755.72e81d24@lxorguk.ukuu.org.uk>
Hi Alan,
> > please comment on following patch.
>
> Why move them out - why not just make them const ?
There's 2 options:
1) we only make them const now. And we move them out later when we do the conversion to the generic watchdog api (which means that we will rip out the code for the open, release, write and ioctl handling of /dev/watchdog) or
2) we make them const and move them out of ioctl and then the ripping out of the code is much easier.
I opted for the second option.
Kind regards,
Wim.
next prev parent reply other threads:[~2010-01-19 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 21:17 [RFC] [PATCH] watchdog_info separation and constify Wim Van Sebroeck
2010-01-19 21:27 ` Alan Cox
2010-01-19 22:00 ` Wim Van Sebroeck [this message]
2010-01-19 21:42 ` Joe Perches
2010-01-19 21:52 ` Mike Frysinger
2010-01-19 22:16 ` Mark Brown
2010-01-19 22:36 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119220014.GG3804@infomag.iguana.be \
--to=wim@iguana.be \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=florian@openwrt.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).