From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
Jay Vosburgh <fubar@us.ibm.com>,
Ron Mercer <ron.mercer@qlogic.com>,
kaneshige.kenji@jp.fujitsu.com, linuxppc-dev@lists.ozlabs.org,
Breno Leitao <leitao@linux.vnet.ibm.com>
Subject: Re: [RFC PATCH] PCI-E broken on PPC (regression)
Date: Mon, 25 Jan 2010 17:50:25 -0800 [thread overview]
Message-ID: <20100125175025.4c74f412@jbarnes-piketon> (raw)
In-Reply-To: <20100125123849.111fa2d1@jbarnes-piketon>
On Mon, 25 Jan 2010 12:38:49 -0800
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Mon, 25 Jan 2010 11:42:29 -0200
> Breno Leitao <leitao@linux.vnet.ibm.com> wrote:
>
> > Hello,
> >
> > I found that qlge is broken on PPC, and it got broken after commit
> > 06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because
> > dev->pcie is not set on PPC, because the function
> > set_pcie_port_type(), who sets dev->pcie, is not being called on PPC
> > PCI code.
>
> You mean dev->is_pcie?
>
> Why isn't pci_scan_device calling pci_setup_device for you? That
> should do the proper PCIe init depending on the device, along with
> extracting other device info...
Cc'ing Ben for PPC. Ben, should PPC use pci_scan_device when probing
its root busses? Sounds like it just uses pci_device_add for each one
it finds instead?
If you don't actually need scanning (though what about hotplug?) we can
move the call to device_add instead...
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-01-26 1:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 13:42 [RFC PATCH] PCI-E broken on PPC (regression) Breno Leitao
2010-01-25 20:38 ` Jesse Barnes
2010-01-26 1:50 ` Jesse Barnes [this message]
2010-01-26 2:59 ` Benjamin Herrenschmidt
2010-01-26 4:36 ` Kenji Kaneshige
2010-01-27 2:10 ` Benjamin Herrenschmidt
2010-01-27 16:26 ` Jesse Barnes
2010-01-27 22:00 ` Benjamin Herrenschmidt
2010-01-28 0:01 ` David Miller
2010-01-28 0:03 ` Jesse Barnes
2010-01-29 3:45 ` Matthew Wilcox
2010-01-29 3:54 ` Benjamin Herrenschmidt
2010-02-18 0:22 ` David Miller
2010-02-18 0:29 ` Jesse Barnes
2010-01-26 4:18 ` Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125175025.4c74f412@jbarnes-piketon \
--to=jbarnes@virtuousgeek.org \
--cc=fubar@us.ibm.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).