From: David Miller <davem@davemloft.net>
To: benh@kernel.crashing.org
Cc: linux-pci@vger.kernel.org, fubar@us.ibm.com,
jbarnes@virtuousgeek.org, ron.mercer@qlogic.com,
kaneshige.kenji@jp.fujitsu.com, linuxppc-dev@lists.ozlabs.org,
leitao@linux.vnet.ibm.com
Subject: Re: [RFC PATCH] PCI-E broken on PPC (regression)
Date: Wed, 27 Jan 2010 16:01:21 -0800 (PST) [thread overview]
Message-ID: <20100127.160121.71577531.davem@davemloft.net> (raw)
In-Reply-To: <1264629612.3601.176.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Thu, 28 Jan 2010 09:00:12 +1100
> On Wed, 2010-01-27 at 08:26 -0800, Jesse Barnes wrote:
>>
>> Thanks Ben. Any refactoring we need to handle this stuff better is
>> fine with me too. I guess on some platforms calling pci_setup_device
>> may cause problems with special platform devices?
>
> Well, we don't call pci_setup_device() because part of the deal is to
> avoid all of that config space reading that it does :-) Especially in
> the case of some of the IBM EADS bridges which don't let you access
> everything we may want.
Same problem on sparc64, it's not safe to poke config space
arbitrarily. Some PCI controllers even have bugs which cause them to
hang if you try to access some parts of the host controller's PCI
config space.
next prev parent reply other threads:[~2010-01-28 0:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 13:42 [RFC PATCH] PCI-E broken on PPC (regression) Breno Leitao
2010-01-25 20:38 ` Jesse Barnes
2010-01-26 1:50 ` Jesse Barnes
2010-01-26 2:59 ` Benjamin Herrenschmidt
2010-01-26 4:36 ` Kenji Kaneshige
2010-01-27 2:10 ` Benjamin Herrenschmidt
2010-01-27 16:26 ` Jesse Barnes
2010-01-27 22:00 ` Benjamin Herrenschmidt
2010-01-28 0:01 ` David Miller [this message]
2010-01-28 0:03 ` Jesse Barnes
2010-01-29 3:45 ` Matthew Wilcox
2010-01-29 3:54 ` Benjamin Herrenschmidt
2010-02-18 0:22 ` David Miller
2010-02-18 0:29 ` Jesse Barnes
2010-01-26 4:18 ` Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127.160121.71577531.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=fubar@us.ibm.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).