From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-mail-158.bluehost.com (outbound-mail-158.bluehost.com [67.222.39.38]) by ozlabs.org (Postfix) with SMTP id A337BB7D03 for ; Thu, 28 Jan 2010 11:10:46 +1100 (EST) Date: Wed, 27 Jan 2010 16:03:48 -0800 From: Jesse Barnes To: David Miller Subject: Re: [RFC PATCH] PCI-E broken on PPC (regression) Message-ID: <20100127160348.3c5b0741@jbarnes-piketon> In-Reply-To: <20100127.160121.71577531.davem@davemloft.net> References: <1264558256.3601.153.camel@pasglop> <20100127082624.4a91323a@jbarnes-piketon> <1264629612.3601.176.camel@pasglop> <20100127.160121.71577531.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: fubar@us.ibm.com, linux-pci@vger.kernel.org, ron.mercer@qlogic.com, kaneshige.kenji@jp.fujitsu.com, linuxppc-dev@lists.ozlabs.org, leitao@linux.vnet.ibm.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 27 Jan 2010 16:01:21 -0800 (PST) David Miller wrote: > From: Benjamin Herrenschmidt > Date: Thu, 28 Jan 2010 09:00:12 +1100 > > > On Wed, 2010-01-27 at 08:26 -0800, Jesse Barnes wrote: > >> > >> Thanks Ben. Any refactoring we need to handle this stuff better is > >> fine with me too. I guess on some platforms calling pci_setup_device > >> may cause problems with special platform devices? > > > > Well, we don't call pci_setup_device() because part of the deal is to > > avoid all of that config space reading that it does :-) Especially in > > the case of some of the IBM EADS bridges which don't let you access > > everything we may want. > > Same problem on sparc64, it's not safe to poke config space > arbitrarily. Some PCI controllers even have bugs which cause them to > hang if you try to access some parts of the host controller's PCI > config space. Ok, that's what I thought. We'll need to make these functions available then... -- Jesse Barnes, Intel Open Source Technology Center