From: Wolfgang Denk <wd@denx.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Piotr Ziecik <kosmo@semihalf.com>,
dzu@denx.de, linuxppc-dev@ozlabs.org,
linux-mtd@lists.infradead.org, Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH 3/8 v2] mtd: Add MPC5121 NAND Flash Controller driver
Date: Wed, 27 Jan 2010 21:24:27 +0100 [thread overview]
Message-ID: <20100127202427.D311CD334C9@gemini.denx.de> (raw)
In-Reply-To: <fa686aa41001270843u3b4e9687k699ad579de4460d4@mail.gmail.com>
Dear Grant Likely,
In message <fa686aa41001270843u3b4e9687k699ad579de4460d4@mail.gmail.com> you wrote:
>
> > + if (rev != 2) {
> > + dev_err(dev, "SoC revision %u is not supported!\n", rev);
> > + return -ENXIO;
> > + }
>
> *Only* revision 2? Are future revisions of silicon assumed to be broken then?
I vote for keeping it this way - if you look at the diffferences
between revision 1 and 2, or at differences between MPC5121/3 and
MPC5125, it is more than likely that revision 3, should it ever come
out, will be incompatible and require driver changes.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Landru! Guide us!
-- A Beta 3-oid, "The Return of the Archons", stardate 3157.4
next prev parent reply other threads:[~2010-01-27 20:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 12:07 [PATCH 0/8] Update support for MPC512x Anatolij Gustschin
2010-01-27 12:07 ` [PATCH 1/8 v2] powerpc/mpc5121: Add machine restart support Anatolij Gustschin
2010-01-27 15:46 ` Grant Likely
2010-01-27 12:07 ` [PATCH 2/8 v2] rtc: Add MPC5121 Real time clock driver Anatolij Gustschin
2010-01-27 15:58 ` Grant Likely
2010-01-27 12:07 ` [PATCH 3/8 v2] mtd: Add MPC5121 NAND Flash Controller driver Anatolij Gustschin
2010-01-27 16:43 ` Grant Likely
2010-01-27 20:24 ` Wolfgang Denk [this message]
2010-01-27 12:07 ` [PATCH 4/8 v2] dma: Add MPC512x DMA driver Anatolij Gustschin
2010-01-27 12:07 ` [PATCH 5/8 v2] powerpc/mpc5121: add USB host support Anatolij Gustschin
2010-01-27 12:36 ` Jan Andersson
2010-01-27 15:45 ` Anatolij Gustschin
2010-01-27 16:54 ` Grant Likely
2010-01-27 12:07 ` [PATCH 6/8 v2] powerpc/mpc5121: shared DIU framebuffer support Anatolij Gustschin
2010-01-27 12:07 ` [PATCH 7/8 v2] powerpc/mpc5121: update mpc5121ads DTS Anatolij Gustschin
2010-01-27 12:07 ` [PATCH 8/8 v2] powerpc/mpc5121: Add default config for MPC5121 Anatolij Gustschin
2010-01-27 14:23 ` [PATCH 0/8] Update support for MPC512x Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127202427.D311CD334C9@gemini.denx.de \
--to=wd@denx.de \
--cc=agust@denx.de \
--cc=dzu@denx.de \
--cc=grant.likely@secretlab.ca \
--cc=kosmo@semihalf.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).