From: Corey Minyard <minyard@acm.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: [PATCH] powerpc: Add coherent_dma_mask setting to platform devices
Date: Mon, 01 Feb 2010 13:36:47 -0600 [thread overview]
Message-ID: <20100201193647.GA10863@minyard.local> (raw)
In-Reply-To: <1265000313.8287.25.camel@pasglop>
From: Corey Minyard <cminyard@mvista.com>
DMA ops requires that coherent_dma_mask be set properly for a device,
but this was not being done for platform devices on powerpc. The
MPSC drivers, in particular, need this for both serial and ethernet
or they won't be able to allocate memory.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
How about this patch? It seems to work ok and I suppose this makes
sense. I'll send the uart setting in another patch.
Index: linux-2.6/arch/powerpc/kernel/setup-common.c
===================================================================
--- linux-2.6.orig/arch/powerpc/kernel/setup-common.c
+++ linux-2.6/arch/powerpc/kernel/setup-common.c
@@ -681,6 +681,7 @@ static int ppc_dflt_bus_notify(struct no
return 0;
set_dma_ops(dev, &dma_direct_ops);
+ pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
return NOTIFY_DONE;
}
prev parent reply other threads:[~2010-02-01 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-30 0:04 [PATCH] powerpc: Add DMA mask to MPSC serial and network and UART device to serial Corey Minyard
2010-02-01 4:58 ` Benjamin Herrenschmidt
2010-02-01 18:00 ` Corey Minyard
2010-02-02 7:38 ` Benjamin Herrenschmidt
2010-02-01 19:36 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201193647.GA10863@minyard.local \
--to=minyard@acm.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).