From: Christoph Hellwig <hch@lst.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>,
Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH 1/7] powerpc: Reduce footprint of irq_stat
Date: Tue, 2 Feb 2010 09:19:40 +0100 [thread overview]
Message-ID: <20100202081940.GA7552@lst.de> (raw)
In-Reply-To: <1265065630.8287.46.camel@pasglop>
On Tue, Feb 02, 2010 at 10:07:10AM +1100, Benjamin Herrenschmidt wrote:
> On Mon, 2010-02-01 at 22:55 +0100, Christoph Hellwig wrote:
>
> > > +typedef struct {
> > > + unsigned int __softirq_pending;
> > > +} ____cacheline_aligned irq_cpustat_t;
> >
> > No need to bother with an irq_cpustat_t type at all in this case, just
> > declare a softirq_pending per-cpu variable.
>
> I think his subsequent patches add members to that struct for
> CE, MCE etc... stats.
Well, if you want those in a structure for arch-local reasons please
give them an arch-local name. I really want to get rid of the current
concept of a generic irq_cpustat_t - it doens't make much sense in
it's current form. Instead the API will be the local_softirq_pending()
function/macro with arch specific or a generic implementation.
prev parent reply other threads:[~2010-02-02 8:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 6:30 [PATCH 1/7] powerpc: Reduce footprint of irq_stat Anton Blanchard
2010-02-01 6:32 ` [PATCH 2/7] powerpc: Reduce footprint of xics_ipi_struct Anton Blanchard
2010-02-01 6:33 ` [PATCH 3/7] powerpc: Rework /proc/interrupts Anton Blanchard
2010-02-01 6:33 ` [PATCH 4/7] powerpc: Remove whitespace in irq chip name fields Anton Blanchard
2010-02-01 6:34 ` [PATCH 5/7] powerpc: Add timer, performance monitor and machine check counts to /proc/interrupts Anton Blanchard
2010-02-01 6:34 ` [PATCH 6/7] powerpc: Convert global "BAD" interrupt to per cpu spurious Anton Blanchard
2010-02-01 6:34 ` [PATCH 7/7] powerpc: Increase NR_IRQS Kconfig maximum to 32768 Anton Blanchard
2010-02-01 21:55 ` [PATCH 1/7] powerpc: Reduce footprint of irq_stat Christoph Hellwig
2010-02-01 23:07 ` Benjamin Herrenschmidt
2010-02-02 8:19 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100202081940.GA7552@lst.de \
--to=hch@lst.de \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).