From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "R58472@freescale.com" <R58472@freescale.com>,
"B04825@freescale.com" <B04825@freescale.com>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
"scottwood@freescale.com" <scottwood@freescale.com>,
"Dipen.Dudhat@freescale.com" <Dipen.Dudhat@freescale.com>,
"Maneesh.Gupta@freescale.com" <Maneesh.Gupta@freescale.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
Subject: Re: [PATCH 8/8] fsldma: major cleanups and fixes
Date: Tue, 2 Feb 2010 13:36:54 -0800 [thread overview]
Message-ID: <20100202213654.GD2609@ovro.caltech.edu> (raw)
In-Reply-To: <4B6897BC.60203@intel.com>
On Tue, Feb 02, 2010 at 02:23:08PM -0700, Dan Williams wrote:
> Ira W. Snyder wrote:
> > In the fsldma driver, all callbacks are run from tasklet (softirq)
> > context. That's under local_irq_disable(), right? Hardirq's certainly
> > aren't disabled there.
>
> Actually, my mistake, the cleanup routine does spin_lock_irqsave(), but
> I now see that it drops the lock across the callback:
>
> /* Run the link descriptor callback function */
> if (callback) {
> spin_unlock_irqrestore(&fsl_chan->desc_lock, flags);
> dev_dbg(fsl_chan->dev, "link descriptor %p callback\n", desc);
> callback(callback_param);
> spin_lock_irqsave(&fsl_chan->desc_lock, flags);
> }
>
> ...so I retract my comment about surprising the raid5 code.
I'm glad to hear that :)
Thanks for picking up the patches.
Ira
next prev parent reply other threads:[~2010-02-02 21:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 23:33 [PATCH 0/8 v2] fsldma: cleanup driver and fix async_tx compatibility Ira W. Snyder
2010-01-06 23:33 ` [PATCH 1/8] fsldma: reduce kernel text size Ira W. Snyder
2010-01-06 23:34 ` [PATCH 2/8] fsldma: remove unused structure members Ira W. Snyder
2010-01-06 23:34 ` [PATCH 3/8] fsldma: rename struct fsl_dma_chan to struct fsldma_chan Ira W. Snyder
2010-01-06 23:34 ` [PATCH 4/8] fsldma: rename dest to dst for uniformity Ira W. Snyder
2010-01-06 23:34 ` [PATCH 5/8] fsldma: clean up the OF subsystem routines Ira W. Snyder
2010-01-06 23:34 ` [PATCH 6/8] fsldma: simplify IRQ probing and handling Ira W. Snyder
2010-01-06 23:34 ` [PATCH 7/8] fsldma: rename fsl_chan to chan Ira W. Snyder
2010-01-06 23:34 ` [PATCH 8/8] fsldma: major cleanups and fixes Ira W. Snyder
2010-02-02 21:02 ` Dan Williams
2010-02-02 21:16 ` Ira W. Snyder
2010-02-02 21:23 ` Dan Williams
2010-02-02 21:36 ` Ira W. Snyder [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-01 6:10 fsldma: cleanup driver and fix async_tx compatibility Ira W. Snyder
2010-01-01 6:10 ` [PATCH 8/8] fsldma: major cleanups and fixes Ira W. Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100202213654.GD2609@ovro.caltech.edu \
--to=iws@ovro.caltech.edu \
--cc=B04825@freescale.com \
--cc=Dipen.Dudhat@freescale.com \
--cc=Maneesh.Gupta@freescale.com \
--cc=R58472@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).